From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK6rH-00016g-Fx for qemu-devel@nongnu.org; Wed, 20 Aug 2014 10:27:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XK6r9-0002w8-QH for qemu-devel@nongnu.org; Wed, 20 Aug 2014 10:27:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XK6r9-0002vs-IP for qemu-devel@nongnu.org; Wed, 20 Aug 2014 10:27:19 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KERIp5011831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 10:27:18 -0400 Date: Wed, 20 Aug 2014 15:27:16 +0100 From: Stefan Hajnoczi Message-ID: <20140820142716.GA3673@stefanha-thinkpad.redhat.com> References: <1408050186-27800-1-git-send-email-jsnow@redhat.com> <20140818131229.GB1273@stefanha-thinkpad.redhat.com> <53F3A366.1010307@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft" Content-Disposition: inline In-Reply-To: <53F3A366.1010307@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com --/04w6evG8XlLl3ft Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 19, 2014 at 03:20:06PM -0400, John Snow wrote: >=20 >=20 > On 08/18/2014 09:12 AM, Stefan Hajnoczi wrote: > >On Thu, Aug 14, 2014 at 05:03:06PM -0400, John Snow wrote: > >>@@ -162,10 +173,10 @@ static void ide_identify(IDEState *s) > >> } > >> put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported */ > >> put_le16(p + 93, 1 | (1 << 14) | 0x2000); > >>- put_le16(p + 100, s->nb_sectors); > >>- put_le16(p + 101, s->nb_sectors >> 16); > >>- put_le16(p + 102, s->nb_sectors >> 32); > >>- put_le16(p + 103, s->nb_sectors >> 48); > >>+ /* *(p + 100) :=3D nb_sectors -- see ide_identify_size */ > >>+ /* *(p + 101) :=3D nb_sectors >> 16 -- see ide_identify_size */ > >>+ /* *(p + 102) :=3D nb_sectors >> 32 -- see ide_identify_size */ > >>+ /* *(p + 103) :=3D nb_sectors >> 48 -- see ide_identify_size */ > > > >These comments bitrot easily. I'd prefer not to have them, but not a > >reason to respin: > > > >Reviewed-by: Stefan Hajnoczi > > >=20 > Ping? Respin w/o comments, or is this fine? I gave my Reviewed-by: and am not asking for a respin. --/04w6evG8XlLl3ft Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT9LBEAAoJEJykq7OBq3PIk5AH/0nBdyiSKNu9t/nmVMgqB6hA 9daEfj99/uMhDcm9pyXeiDBNzlFTD+qhZwkj9lzWhzGX4VHiUVgvotvoTEqLbI+4 xJOKbyj5RknRjvBEKUbvrgFEoAbQvYt3zyWoa9KBaRk+DcGOfKRbqkAKs5zUEt5n sH3UK9wX1z60j3KNexUCE2knJaqHTw//4w7jzfQ4UHgTO3hUXkWEIPIiwwJIK7Pz HloRjVsZRl5vefFjx8a2AS61IJ3UberH4SVcsNbPEVIhJMOD3s4GSjU1kCj7Q5JP IIYY0VQOGhXFZxV5cAq/AAOk2zjbTV0R2RNl+WWzSMBW70vp6QqZyKvttn4F1yM= =wH3G -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft--