From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XKBq5-0006WK-Av
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:46:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XKBq1-0003ie-Vk
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:46:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59562)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XKBq1-0003iZ-OG
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:46:29 -0400
Date: Wed, 20 Aug 2014 21:46:54 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140820194654.GA28473@redhat.com>
References: <1408513950-16048-1-git-send-email-arei.gonglei@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1408513950-16048-1-git-send-email-arei.gonglei@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v2] pcihp: fix possible array out of bounds
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com
Cc: peter.crosthwaite@xilinx.com, weidong.huang@huawei.com, qemu-devel@nongnu.org, marcel.a@redhat.com

On Wed, Aug 20, 2014 at 01:52:30PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> Prevent out-of-bounds array access on
> acpi_pcihp_pci_status.
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Applied, thanks!
> ---
> v2: 
>  - change commit message.
>  - add 'Reviewed-by'
> ---
>  hw/acpi/pcihp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
> index fae663a..34dedf1 100644
> --- a/hw/acpi/pcihp.c
> +++ b/hw/acpi/pcihp.c
> @@ -231,7 +231,7 @@ static uint64_t pci_read(void *opaque, hwaddr addr, unsigned int size)
>      uint32_t val = 0;
>      int bsel = s->hotplug_select;
>  
> -    if (bsel < 0 || bsel > ACPI_PCIHP_MAX_HOTPLUG_BUS) {
> +    if (bsel < 0 || bsel >= ACPI_PCIHP_MAX_HOTPLUG_BUS) {
>          return 0;
>      }
>  
> -- 
> 1.7.12.4
>