From: Stefan Hajnoczi <stefanha@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] What tests should "make check-block" run?
Date: Thu, 21 Aug 2014 14:12:37 +0100 [thread overview]
Message-ID: <20140821131237.GA22844@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <87oave58q3.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]
On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote:
> Should "make check-block" run more tests? Which ones?
Let's add image format specific test cases to "make check-block" (e.g.
VHDX and VMDK). For these formats we would not run the standard tests,
only the format-specific test cases.
That way "make check-block" stays fast but gets a lot more coverage.
> Should we have a variant of "make check-block" for testing other
> (format, protocol) combinations?
I don't think variants are useful. If you need control, use ./check.
> Should we have a variant of "make check-block" that tests everything
> that's testable without special setup?
>
> How can we make advanced iotest features more discoverable for
> developers not already intimately familiar with it?
The limiting factor is test execution speed. If tests are very fast we
can run more of them without annoying the user.
If anyone wants to optimize test run times, that would be very welcome.
Here is a list of the longest test cases:
026 116s
041 56s
023 43s
015 29s
014 29s
There are some more test cases that take more than 10s which I have not
listed. Ideally all test cases would take less than 5s.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-08-21 13:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 12:27 [Qemu-devel] What tests should "make check-block" run? Markus Armbruster
2014-08-21 12:52 ` Paolo Bonzini
2014-08-21 13:00 ` Peter Crosthwaite
2014-08-22 5:01 ` Fam Zheng
2014-08-21 14:38 ` Kevin Wolf
2014-08-21 13:12 ` Stefan Hajnoczi [this message]
2014-08-21 13:16 ` Peter Maydell
2014-08-28 11:05 ` Stefan Hajnoczi
2014-08-28 15:22 ` Jeff Cody
2014-08-28 15:24 ` Markus Armbruster
2014-08-28 16:19 ` Peter Maydell
2014-08-29 20:05 ` Max Reitz
2014-09-01 7:55 ` Markus Armbruster
2014-08-28 23:50 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821131237.GA22844@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).