From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] What tests should "make check-block" run?
Date: Thu, 21 Aug 2014 16:38:32 +0200 [thread overview]
Message-ID: <20140821143832.GH4452@noname.redhat.com> (raw)
In-Reply-To: <53F5EB87.2020004@redhat.com>
Am 21.08.2014 um 14:52 hat Paolo Bonzini geschrieben:
> Il 21/08/2014 14:27, Markus Armbruster ha scritto:
> > Current "make check-block" runs tests/qemu-iotests-quick.sh, which tests
> > format qcow2, protocol file, group quick with cache=none. Runs 55 tests
> > and takes about 2 minutes for me on a not particularly fast test box
> > (spinning rust).
>
> Perhaps "make check" should run these quick tests, while "make
> check-block" should run a bigger testsuite.
Yes, I think that make sense.
> The caveat about cache=none applies; perhaps tests/qemu-iotests-quick.sh
> could check for that.
We could just use -c writeback now that qemu-iotests has this option.
The reason for -nocache was simply that writethrough is too slow.
Kevin
next prev parent reply other threads:[~2014-08-21 14:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 12:27 [Qemu-devel] What tests should "make check-block" run? Markus Armbruster
2014-08-21 12:52 ` Paolo Bonzini
2014-08-21 13:00 ` Peter Crosthwaite
2014-08-22 5:01 ` Fam Zheng
2014-08-21 14:38 ` Kevin Wolf [this message]
2014-08-21 13:12 ` Stefan Hajnoczi
2014-08-21 13:16 ` Peter Maydell
2014-08-28 11:05 ` Stefan Hajnoczi
2014-08-28 15:22 ` Jeff Cody
2014-08-28 15:24 ` Markus Armbruster
2014-08-28 16:19 ` Peter Maydell
2014-08-29 20:05 ` Max Reitz
2014-09-01 7:55 ` Markus Armbruster
2014-08-28 23:50 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821143832.GH4452@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).