From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45606)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XKTVg-0000s1-Vi
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 10:38:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XKTVb-0003Z7-IN
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 10:38:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3962)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1XKTVb-0003Yu-Bg
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 10:38:35 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7LEcYl0004752
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 21 Aug 2014 10:38:34 -0400
Date: Thu, 21 Aug 2014 16:38:32 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140821143832.GH4452@noname.redhat.com>
References: <87oave58q3.fsf@blackfin.pond.sub.org>
	<53F5EB87.2020004@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53F5EB87.2020004@redhat.com>
Subject: Re: [Qemu-devel] What tests should "make check-block" run?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org

Am 21.08.2014 um 14:52 hat Paolo Bonzini geschrieben:
> Il 21/08/2014 14:27, Markus Armbruster ha scritto:
> > Current "make check-block" runs tests/qemu-iotests-quick.sh, which tests
> > format qcow2, protocol file, group quick with cache=none.  Runs 55 tests
> > and takes about 2 minutes for me on a not particularly fast test box
> > (spinning rust).
> 
> Perhaps "make check" should run these quick tests, while "make
> check-block" should run a bigger testsuite.

Yes, I think that make sense.

> The caveat about cache=none applies; perhaps tests/qemu-iotests-quick.sh
> could check for that.

We could just use -c writeback now that qemu-iotests has this option.
The reason for -nocache was simply that writethrough is too slow.

Kevin