From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKVkU-0003rH-TU for qemu-devel@nongnu.org; Thu, 21 Aug 2014 13:02:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKVkL-0004Tj-VD for qemu-devel@nongnu.org; Thu, 21 Aug 2014 13:02:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKVkL-0004Ta-OB for qemu-devel@nongnu.org; Thu, 21 Aug 2014 13:01:57 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7LH1tks007955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 21 Aug 2014 13:01:56 -0400 Date: Thu, 21 Aug 2014 18:01:53 +0100 From: Stefan Hajnoczi Message-ID: <20140821170153.GF22844@stefanha-thinkpad.redhat.com> References: <1408622216-9578-1-git-send-email-famz@redhat.com> <1408622216-9578-9-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SxgehGEc6vB0cZwN" Content-Disposition: inline In-Reply-To: <1408622216-9578-9-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 8/9] block: Implement stub bdrv_em_co_aiocb_info.cancel_async List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org --SxgehGEc6vB0cZwN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 21, 2014 at 07:56:55PM +0800, Fam Zheng wrote: > diff --git a/block.c b/block.c > index 1cc8926..1860e4b 100644 > --- a/block.c > +++ b/block.c > @@ -4750,9 +4750,14 @@ static void bdrv_aio_co_cancel_em(BlockDriverAIOCB= *blockacb) > } > } > =20 > +static void bdrv_aio_co_cancel_em_async(BlockDriverAIOCB *blockacb) > +{ > +} Please include a comment to explain why this function body is empty: /* Do nothing, let caller wait for the request to complete */ --SxgehGEc6vB0cZwN Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT9iYBAAoJEJykq7OBq3PIQGIH/jNjVaboFPx/feM1elEK41Ty kbOhwFSniQ2ZlIsH1s/uP1nlxocOTmjW97X6+ajJWPptcsr/MYRuYav1Ah/f5yd3 g/6j0Y8u3VfrAkrVHpOQuuF7awD0GgyQdiKoA9FIZFflgaAuwsv0fvDplAA5t2Ni YXw7LT84pGut2XDVy17uuc8TpYvCrGPhKWRjytyvQnGuEg70Mc6jud8r4wFu1N39 hC+tf/AW+Pb3H2banBA4iYsP9kUDger77xeYT8mC594HMLYQp5QM38nmGJe4GBUO mBtpfmfsk/IRA6/CZowATGlq/bYng5R9wIQaNCEaGpKPgqC1gBvsU0dlmQV9I2s= =foSx -----END PGP SIGNATURE----- --SxgehGEc6vB0cZwN--