From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKfyy-0006IW-KR for qemu-devel@nongnu.org; Thu, 21 Aug 2014 23:57:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKfys-000187-Eh for qemu-devel@nongnu.org; Thu, 21 Aug 2014 23:57:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKfys-00017o-6x for qemu-devel@nongnu.org; Thu, 21 Aug 2014 23:57:38 -0400 Date: Fri, 22 Aug 2014 09:27:23 +0530 From: Amit Shah Message-ID: <20140822035723.GA16198@grmbl.mre> References: <874mz919w5.fsf@troll.troll> <20140709042557.GA10283@grmbl.mre> <20140709104457.GE27615@grmbl.mre> <20140709105620.GG27615@grmbl.mre> <20140711125226.GA17415@grmbl.mre> <8D9E2FF4-9264-49B8-A19C-B71770F9CE11@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8D9E2FF4-9264-49B8-A19C-B71770F9CE11@kamp.de> Subject: Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Peter Maydell , Juan Quintela , QEMU Developers , "Dr. David Alan Gilbert" , Paolo Bonzini On (Thu) 21 Aug 2014 [23:57:46], Peter Lieven wrote: > > Am 11.07.2014 um 14:52 schrieb Amit Shah : > > > On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote: > >> On 9 July 2014 11:56, Amit Shah wrote: > >>> On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote: > >>>> OK; we're treating those as bugs so yes, I think this is 2.1 > >>>> material. Has somebody other than the original author tested > >>>> it? (That's a step that would usually be done by Juan as the > >>>> maintainer.) If somebody can provide a Tested-by: I'm happy > >>>> to apply it to master. > >>> > >>> Not really sure if Juan did that as part of his 'thanks, applied' > >>> workflow, but I'll run this through the autotest migration tests and > >>> report back. > >> > >> Thanks; it seems better to double-check given where we are in > >> the release cycle. > > > > I tested using the autotest migration tests, which start a guest, > > migrate it, and then login to the guest to see if everything's fine. > > > > I used qemu-2.0 and qemu.git against qemu.git+patch and both tests > > passed fine. > > > > But since Peter and Eric have reservations, let's just postpone this > > till 2.2. That saves me from further tests as well! > > Since 2.1 is out meanwhile can you please send a pull request for this > patch now? Juan is back, I'll let him pick it through his tree. Thanks, Amit