From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKmUX-0005FF-44 for qemu-devel@nongnu.org; Fri, 22 Aug 2014 06:54:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKmUQ-0004ed-W7 for qemu-devel@nongnu.org; Fri, 22 Aug 2014 06:54:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKmUQ-0004eV-O4 for qemu-devel@nongnu.org; Fri, 22 Aug 2014 06:54:38 -0400 Date: Fri, 22 Aug 2014 12:54:29 +0200 From: Kevin Wolf Message-ID: <20140822105429.GF32377@noname.redhat.com> References: <20140728084846.GH31917@G08FNSTD100614.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140728084846.GH31917@G08FNSTD100614.fnst.cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Yasunori Goto , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Am 28.07.2014 um 10:48 hat Hu Tao geschrieben: > ping... > > All the 6 patches have reviewed-by now. Looks mostly good to me, I have only a few minor comments that wouldn't block inclusion but could be addressed in follow-up patches. However, you have a dependency on a patch series from Max (you use minimal_blob_size()), which hasn't been reviewed and merged yet, so your series is blocked on that. If you want to get your series merged quicker, you could replace this with a rough estimate that excludes the clusters used by refcount table and blocks. If full preallocation isn't really full, but only preallocation of 99.9%, that's probably good enough in practice. Kevin