From: Kevin Wolf <kwolf@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v12 1/6] block: round up file size to nearest sector
Date: Fri, 22 Aug 2014 12:55:51 +0200 [thread overview]
Message-ID: <20140822105551.GG32377@noname.redhat.com> (raw)
In-Reply-To: <34dd2e12b873387f13fb4a37622fae93450d1530.1405058453.git.hutao@cn.fujitsu.com>
Am 11.07.2014 um 08:09 hat Hu Tao geschrieben:
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
If we make this change, shouldn't we do it consistently across all image
formats? With this patch we have some formats that round up, and many
others that round down.
Kevin
next prev parent reply other threads:[~2014-08-22 10:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 6:09 [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc Hu Tao
2014-07-11 6:09 ` [Qemu-devel] [PATCH v12 1/6] block: round up file size to nearest sector Hu Tao
2014-08-22 10:55 ` Kevin Wolf [this message]
2014-08-25 1:11 ` Hu Tao
2014-07-11 6:09 ` [Qemu-devel] [PATCH v12 2/6] raw, qcow2: don't convert file size to sector size Hu Tao
2014-07-11 6:10 ` [Qemu-devel] [PATCH v12 3/6] rename parse_enum_option to qapi_enum_parse and make it public Hu Tao
2014-07-11 6:10 ` [Qemu-devel] [PATCH v12 4/6] qapi: introduce PreallocMode and a new PreallocMode full Hu Tao
2014-08-22 10:57 ` Kevin Wolf
2014-08-25 1:12 ` Hu Tao
2014-07-11 6:10 ` [Qemu-devel] [PATCH v12 5/6] raw-posix: Add falloc and full preallocation option Hu Tao
2014-08-22 10:58 ` Kevin Wolf
2014-08-25 1:18 ` Hu Tao
2014-07-11 6:10 ` [Qemu-devel] [PATCH v12 6/6] qcow2: " Hu Tao
2014-07-11 21:07 ` Max Reitz
2014-08-22 11:00 ` Kevin Wolf
2014-08-25 1:36 ` Hu Tao
2014-07-28 8:48 ` [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc Hu Tao
2014-08-22 10:54 ` Kevin Wolf
2014-08-25 1:35 ` Hu Tao
2014-08-26 10:44 ` Stefan Hajnoczi
2014-08-28 5:04 ` Hu Tao
2014-08-22 12:25 ` Richard W.M. Jones
2014-08-22 12:36 ` Daniel P. Berrange
2014-08-22 13:13 ` Kevin Wolf
2014-08-22 13:26 ` Richard W.M. Jones
2014-08-22 14:20 ` Daniel P. Berrange
2014-08-22 15:22 ` Kevin Wolf
2014-08-22 15:34 ` Richard W.M. Jones
2014-08-22 15:39 ` Richard W.M. Jones
2014-08-22 15:53 ` Kevin Wolf
2014-08-22 16:00 ` Richard W.M. Jones
2014-08-25 5:18 ` Hu Tao
2014-08-25 10:31 ` Richard W.M. Jones
2014-08-25 13:44 ` Richard W.M. Jones
2014-08-26 5:27 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822105551.GG32377@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).