From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKmVp-0007MF-Tn for qemu-devel@nongnu.org; Fri, 22 Aug 2014 06:56:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKmVl-0005RT-0e for qemu-devel@nongnu.org; Fri, 22 Aug 2014 06:56:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKmVk-0005R4-Qd for qemu-devel@nongnu.org; Fri, 22 Aug 2014 06:56:00 -0400 Date: Fri, 22 Aug 2014 12:55:51 +0200 From: Kevin Wolf Message-ID: <20140822105551.GG32377@noname.redhat.com> References: <34dd2e12b873387f13fb4a37622fae93450d1530.1405058453.git.hutao@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34dd2e12b873387f13fb4a37622fae93450d1530.1405058453.git.hutao@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v12 1/6] block: round up file size to nearest sector List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Yasunori Goto , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Am 11.07.2014 um 08:09 hat Hu Tao geschrieben: > Reviewed-by: Max Reitz > Reviewed-by: Eric Blake > Signed-off-by: Hu Tao If we make this change, shouldn't we do it consistently across all image formats? With this patch we have some formats that round up, and many others that round down. Kevin