From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKtBk-00057W-1F for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:03:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKtBe-0006SD-PH for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:03:47 -0400 Received: from dew.nodalink.com ([95.130.14.197]:39924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKtBe-0006QI-GW for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:03:42 -0400 Date: Fri, 22 Aug 2014 18:03:41 +0000 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140822180341.GC9526@nodalink.com> References: <1408725104-17176-1-git-send-email-mreitz@redhat.com> <1408725104-17176-3-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1408725104-17176-3-git-send-email-mreitz@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 02/10] qcow2: Split qcow2_check_refcounts() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , =?iso-8859-1?Q?Beno=EEt?= Canet On Fri, Aug 22, 2014 at 06:31:36PM +0200, Max Reitz wrote: > Put the code for calculating the reference counts and comparing them > during qemu-img check into own functions. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 153 ++++++++++++++++++++++++++++++++---------= -------- > 1 file changed, 102 insertions(+), 51 deletions(-) >=20 > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index 43665b8..5f0920b 100644 > --- a/block/qcow2-refcount.c > +++ b/block/qcow2-refcount.c > @@ -1496,71 +1496,70 @@ done: > return new_offset; > } > =20 > +static int check_refblocks(BlockDriverState *bs, BdrvCheckResult *res, > + BdrvCheckMode fix, uint16_t **refcount_tabl= e, > + int64_t *nb_clusters); > + > /* > - * Checks an image for refcount consistency. > - * > - * Returns 0 if no errors are found, the number of errors in case the = image is > - * detected as corrupted, and -errno when an internal error occurred. > + * Calculates an in-memory refcount table. > */ > -int qcow2_check_refcounts(BlockDriverState *bs, BdrvCheckResult *res, > - BdrvCheckMode fix) > +static int calculate_refcounts(BlockDriverState *bs, BdrvCheckResult *= res, > + BdrvCheckMode fix, uint16_t **refcount_= table, > + int64_t *nb_clusters) > { > BDRVQcowState *s =3D bs->opaque; > - int64_t size, i, highest_cluster, nb_clusters; > - int refcount1, refcount2; > + int64_t i; > QCowSnapshot *sn; > - uint16_t *refcount_table; > int ret; > =20 > - size =3D bdrv_getlength(bs->file); > - if (size < 0) { > - res->check_errors++; > - return size; > - } > - > - nb_clusters =3D size_to_clusters(s, size); > - if (nb_clusters > INT_MAX) { > - res->check_errors++; > - return -EFBIG; > - } > - > - refcount_table =3D g_try_new0(uint16_t, nb_clusters); > - if (nb_clusters && refcount_table =3D=3D NULL) { > + *refcount_table =3D g_try_new0(uint16_t, *nb_clusters); > + if (*nb_clusters && *refcount_table =3D=3D NULL) { > res->check_errors++; > return -ENOMEM; > } > =20 > - res->bfi.total_clusters =3D > - size_to_clusters(s, bs->total_sectors * BDRV_SECTOR_SIZE); > - > /* header */ > - inc_refcounts(bs, res, refcount_table, nb_clusters, > + inc_refcounts(bs, res, *refcount_table, *nb_clusters, > 0, s->cluster_size); > =20 > /* current L1 table */ > - ret =3D check_refcounts_l1(bs, res, refcount_table, nb_clusters, > + ret =3D check_refcounts_l1(bs, res, *refcount_table, *nb_clusters, > s->l1_table_offset, s->l1_size, CHECK_FRA= G_INFO); > if (ret < 0) { > - goto fail; > + return ret; > } > =20 > /* snapshots */ > - for(i =3D 0; i < s->nb_snapshots; i++) { > + for (i =3D 0; i < s->nb_snapshots; i++) { > sn =3D s->snapshots + i; > - ret =3D check_refcounts_l1(bs, res, refcount_table, nb_cluster= s, > + ret =3D check_refcounts_l1(bs, res, *refcount_table, *nb_clust= ers, > sn->l1_table_offset, sn->l1_size, 0); > if (ret < 0) { > - goto fail; > + return ret; > } > } > - inc_refcounts(bs, res, refcount_table, nb_clusters, > + inc_refcounts(bs, res, *refcount_table, *nb_clusters, > s->snapshots_offset, s->snapshots_size); > =20 > /* refcount data */ > - inc_refcounts(bs, res, refcount_table, nb_clusters, > + inc_refcounts(bs, res, *refcount_table, *nb_clusters, > s->refcount_table_offset, > s->refcount_table_size * sizeof(uint64_t)); > =20 > + return check_refblocks(bs, res, fix, refcount_table, nb_clusters); > +} > + > +/* > + * Checks consistency of refblocks and accounts for each refblock in > + * *refcount_table. > + */ > +static int check_refblocks(BlockDriverState *bs, BdrvCheckResult *res, > + BdrvCheckMode fix, uint16_t **refcount_tabl= e, > + int64_t *nb_clusters) > +{ > + BDRVQcowState *s =3D bs->opaque; > + int64_t i; > + > for(i =3D 0; i < s->refcount_table_size; i++) { > uint64_t offset, cluster; > offset =3D s->refcount_table[i]; > @@ -1574,7 +1573,7 @@ int qcow2_check_refcounts(BlockDriverState *bs, B= drvCheckResult *res, > continue; > } > =20 > - if (cluster >=3D nb_clusters) { > + if (cluster >=3D *nb_clusters) { > fprintf(stderr, "ERROR refcount block %" PRId64 > " is outside image\n", i); > res->corruptions++; > @@ -1582,14 +1581,14 @@ int qcow2_check_refcounts(BlockDriverState *bs,= BdrvCheckResult *res, > } > =20 > if (offset !=3D 0) { > - inc_refcounts(bs, res, refcount_table, nb_clusters, > + inc_refcounts(bs, res, *refcount_table, *nb_clusters, > offset, s->cluster_size); > - if (refcount_table[cluster] !=3D 1) { > + if ((*refcount_table)[cluster] !=3D 1) { > fprintf(stderr, "%s refcount block %" PRId64 > " refcount=3D%d\n", > fix & BDRV_FIX_ERRORS ? "Repairing" : > "ERROR", > - i, refcount_table[cluster]); > + i, (*refcount_table)[cluster]); > =20 > if (fix & BDRV_FIX_ERRORS) { > int64_t new_offset; > @@ -1601,17 +1600,18 @@ int qcow2_check_refcounts(BlockDriverState *bs,= BdrvCheckResult *res, > } > =20 > /* update refcounts */ > - if ((new_offset >> s->cluster_bits) >=3D nb_cluste= rs) { > + if ((new_offset >> s->cluster_bits) >=3D *nb_clust= ers) { > /* increase refcount_table size if necessary *= / > - int old_nb_clusters =3D nb_clusters; > - nb_clusters =3D (new_offset >> s->cluster_bits= ) + 1; > - refcount_table =3D g_renew(uint16_t, refcount_= table, > - nb_clusters); > - memset(&refcount_table[old_nb_clusters], 0, (n= b_clusters > - - old_nb_clusters) * sizeof(uint16_t))= ; > + int old_nb_clusters =3D *nb_clusters; > + *nb_clusters =3D (new_offset >> s->cluster_bit= s) + 1; > + *refcount_table =3D g_renew(uint16_t, *refcoun= t_table, > + *nb_clusters); > + memset(&(*refcount_table)[old_nb_clusters], 0, > + (*nb_clusters - old_nb_clusters) * > + sizeof(uint16_t)); > } > - refcount_table[cluster]--; > - inc_refcounts(bs, res, refcount_table, nb_clusters= , > + (*refcount_table)[cluster]--; > + inc_refcounts(bs, res, *refcount_table, *nb_cluste= rs, > new_offset, s->cluster_size); > =20 > res->corruptions_fixed++; > @@ -1622,8 +1622,22 @@ int qcow2_check_refcounts(BlockDriverState *bs, = BdrvCheckResult *res, > } > } > =20 > - /* compare ref counts */ > - for (i =3D 0, highest_cluster =3D 0; i < nb_clusters; i++) { > + return 0; > +} > + > +/* > + * Compares the actual reference count for each cluster in the image a= gainst the > + * refcount as reported by the refcount structures on-disk. > + */ > +static void compare_refcounts(BlockDriverState *bs, BdrvCheckResult *r= es, > + BdrvCheckMode fix, int64_t *highest_clus= ter, > + uint16_t *refcount_table, int64_t nb_clu= sters) > +{ > + BDRVQcowState *s =3D bs->opaque; > + int64_t i; > + int refcount1, refcount2, ret; > + > + for (i =3D 0, *highest_cluster =3D 0; i < nb_clusters; i++) { > refcount1 =3D get_refcount(bs, i); > if (refcount1 < 0) { > fprintf(stderr, "Can't get refcount for cluster %" PRId64 = ": %s\n", > @@ -1635,11 +1649,10 @@ int qcow2_check_refcounts(BlockDriverState *bs,= BdrvCheckResult *res, > refcount2 =3D refcount_table[i]; > =20 > if (refcount1 > 0 || refcount2 > 0) { > - highest_cluster =3D i; > + *highest_cluster =3D i; > } > =20 > if (refcount1 !=3D refcount2) { > - > /* Check if we're allowed to fix the mismatch */ > int *num_fixed =3D NULL; > if (refcount1 > refcount2 && (fix & BDRV_FIX_LEAKS)) { > @@ -1672,6 +1685,44 @@ int qcow2_check_refcounts(BlockDriverState *bs, = BdrvCheckResult *res, > } > } > } > +} > + > +/* > + * Checks an image for refcount consistency. > + * > + * Returns 0 if no errors are found, the number of errors in case the = image is > + * detected as corrupted, and -errno when an internal error occurred. > + */ > +int qcow2_check_refcounts(BlockDriverState *bs, BdrvCheckResult *res, > + BdrvCheckMode fix) > +{ > + BDRVQcowState *s =3D bs->opaque; > + int64_t size, highest_cluster, nb_clusters; > + uint16_t *refcount_table; > + int ret; > + > + size =3D bdrv_getlength(bs->file); > + if (size < 0) { > + res->check_errors++; > + return size; > + } > + > + nb_clusters =3D size_to_clusters(s, size); > + if (nb_clusters > INT_MAX) { > + res->check_errors++; > + return -EFBIG; > + } > + > + res->bfi.total_clusters =3D > + size_to_clusters(s, bs->total_sectors * BDRV_SECTOR_SIZE); > + > + ret =3D calculate_refcounts(bs, res, fix, &refcount_table, &nb_clu= sters); > + if (ret < 0) { > + goto fail; > + } > + > + compare_refcounts(bs, res, fix, &highest_cluster, refcount_table, > + nb_clusters); > =20 > /* check OFLAG_COPIED */ > ret =3D check_oflag_copied(bs, res, fix); > --=20 > 2.0.4 >=20 Thanks it's nicer to read. My opinion changed from "It must be good Max took care of it" to "I did n= ot find any bug" :) Reviewed-by: Beno=EEt Canet