From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59364)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XKtUN-0007qA-B6
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:23:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XKtUI-0003oO-8P
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:23:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35883)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XKtUH-0003oK-WA
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:22:58 -0400
Date: Fri, 22 Aug 2014 20:23:27 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140822182327.GC3780@redhat.com>
References: <1408584508-5946-1-git-send-email-tiejun.chen@intel.com>
	<1408584508-5946-3-git-send-email-tiejun.chen@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1408584508-5946-3-git-send-email-tiejun.chen@intel.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge
 specific to IGD passthrough
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: xen-devel@lists.xensource.com, allen.m.kay@intel.com, qemu-devel@nongnu.org

On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote:
> Currenjly this ISA bridge should be fixed at 1f.0, and pass the
> real vendor/device ids as the driver expect.
> 
> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
> ---
>  hw/i386/pc_piix.c | 24 +++++++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 7710724..b131fa3 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -50,7 +50,8 @@
>  #include "cpu.h"
>  #include "qemu/error-report.h"
>  #ifdef CONFIG_XEN
> -#  include <xen/hvm/hvm_info_table.h>
> +#include <xen/hvm/hvm_info_table.h>
> +#include <hw/xen/xen-host-pci-device.h>
>  #endif
>  
>  #define MAX_IDE_BUS 2
> @@ -463,6 +464,26 @@ static void pc_xen_hvm_init(MachineState *machine)
>      }
>  }
>  
> +static void xen_igd_passthrough_isa_bridge_create(PCIBus *bus)
> +{
> +    struct PCIDevice *dev;
> +    XenHostPCIDevice hdev;
> +    int r = 0;
> +
> +    /* This shoudl be fixed at 1f.0 then pass vendor/device ids.
> +     */
> +    dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0),
> +                            "xen-igd-passthrough-isa-bridge");
> +    if (dev) {
> +        r = xen_host_pci_device_get(&hdev, 0, 0, PCI_DEVFN(0x1f, 0), 0);
> +        if (!r) {
> +            pci_config_set_vendor_id(dev->config, hdev.vendor_id);

No need to override vendor ID, it's intel anyway.

> +            pci_config_set_device_id(dev->config, hdev.device_id);

Please don't do this directly.
Instead, add a property specifying device ID.
Xen can then set this property in Xen code.


> +        } else
> +            fprintf(stderr, "xen set xen-igd-passthrough-isa-bridge failed\n");
> +    }
> +}
> +
>  static void xen_igd_passthrough_pc_hvm_init(MachineState *machine)
>  {
>      PCIBus *bus;
> @@ -472,6 +493,7 @@ static void xen_igd_passthrough_pc_hvm_init(MachineState *machine)
>      bus = pci_find_primary_bus();
>      if (bus != NULL) {
>          pci_create_simple(bus, -1, "xen-platform");
> +        xen_igd_passthrough_isa_bridge_create(bus);
>      }
>  }
>  #endif
> -- 
> 1.9.1