From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34485)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XKtpC-0001vK-Gf
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:44:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XKtp7-0001H1-DV
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:44:34 -0400
Received: from dew.nodalink.com ([95.130.14.197]:39945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XKtp7-0001Gx-81
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 14:44:29 -0400
Date: Fri, 22 Aug 2014 18:44:28 +0000
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>
Message-ID: <20140822184428.GI9526@nodalink.com>
References: <1408725104-17176-1-git-send-email-mreitz@redhat.com>
	<1408725104-17176-2-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1408725104-17176-2-git-send-email-mreitz@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 01/10] qcow2: Fix leaks in dirty images
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>

On Fri, Aug 22, 2014 at 06:31:35PM +0200, Max Reitz wrote:
> When opening dirty images, qcow2's repair function should not only
> repair errors but leaks as well.
>=20
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  block/qcow2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/block/qcow2.c b/block/qcow2.c
> index f9e045f..67d6368 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -898,7 +898,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *=
options, int flags,
>          (s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) {
>          BdrvCheckResult result =3D {0};
> =20
> -        ret =3D qcow2_check(bs, &result, BDRV_FIX_ERRORS);
> +        ret =3D qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LE=
AKS);
>          if (ret < 0) {
>              error_setg_errno(errp, -ret, "Could not repair dirty image=
");
>              goto fail;
> --=20
> 2.0.4
>=20
Reviewed-by: Beno=EEt Canet <benoit.canet@nodalink.com>