From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XLgeL-0006OE-Gv
	for qemu-devel@nongnu.org; Sun, 24 Aug 2014 18:52:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XLgeG-0000rM-Tc
	for qemu-devel@nongnu.org; Sun, 24 Aug 2014 18:52:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11791)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XLgeG-0000qw-Le
	for qemu-devel@nongnu.org; Sun, 24 Aug 2014 18:52:32 -0400
Date: Mon, 25 Aug 2014 00:52:58 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140824225258.GA14580@redhat.com>
References: <1408887140-3320-1-git-send-email-knut.omang@oracle.com>
	<1408887140-3320-5-git-send-email-knut.omang@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1408887140-3320-5-git-send-email-knut.omang@oracle.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Knut Omang <knut.omang@oracle.com>
Cc: Marcel Apfelbaum <marcel.a@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, Juan Quintela <quintela@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Sun, Aug 24, 2014 at 03:32:20PM +0200, Knut Omang wrote:
> Signed-off-by: Knut Omang <knut.omang@oracle.com>

BTW pcie_cap_is_arifwd_enabled is still unused.
We really should use it to make ARI work properly, right?

> ---
>  hw/pci-bridge/ioh3420.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
> index e6674a1..cce2fdd 100644
> --- a/hw/pci-bridge/ioh3420.c
> +++ b/hw/pci-bridge/ioh3420.c
> @@ -85,6 +85,7 @@ static void ioh3420_reset(DeviceState *qdev)
>      pcie_cap_root_reset(d);
>      pcie_cap_deverr_reset(d);
>      pcie_cap_slot_reset(d);
> +    pcie_cap_arifwd_reset(d);
>      pcie_aer_root_reset(d);
>      pci_bridge_reset(qdev);
>      pci_bridge_disable_base_limit(d);
> @@ -119,6 +120,7 @@ static int ioh3420_initfn(PCIDevice *d)
>          goto err_msi;
>      }
>  
> +    pcie_cap_arifwd_init(d);
>      pcie_cap_deverr_init(d);
>      pcie_cap_slot_init(d, s->slot);
>      pcie_chassis_create(s->chassis);
> -- 
> 1.9.0