From: Amos Kong <akong@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name value before setting new one
Date: Mon, 25 Aug 2014 23:59:28 +0800 [thread overview]
Message-ID: <20140825155928.GA1925@zen> (raw)
In-Reply-To: <53E35287.1070608@redhat.com>
On Thu, Aug 07, 2014 at 12:18:47PM +0200, Paolo Bonzini wrote:
> Il 07/08/2014 04:24, Amos Kong ha scritto:
> > Eduardo, a similar patch had been applied.
> >
> > commit 5e490b6a504912225dff0e520e1c6af68295d238
> > Author: Amos Kong <akong@redhat.com>
> > Date: Thu Nov 21 16:42:50 2013 +0800
> >
> > rng-egd: remove redundant free
> >
> > We didn't set default chr_name, the free is redundant.
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > Message-id: 1385023371-8198-2-git-send-email-akong@redhat.com
> > Signed-off-by: Anthony Liguori <aliguori@amazon.com>
> >
>
> What if you set chr_name twice?
In this case, g_free() is necessary.
So I'm fine with Eduardo's patch: [PATCH RESEND 1/2] rng-egd: Free old chr_name value
> Paolo
--
Amos.
next prev parent reply other threads:[~2014-08-25 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 18:18 [Qemu-devel] [PATCH RESEND 0/2] Fix leaks on object_property_add_str() setters Eduardo Habkost
2014-08-06 18:18 ` [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name value before setting new one Eduardo Habkost
2014-08-07 2:24 ` Amos Kong
2014-08-07 10:18 ` Paolo Bonzini
2014-08-25 15:59 ` Amos Kong [this message]
2014-08-06 18:18 ` [Qemu-devel] [PATCH RESEND 2/2] hw/machine: Free old values of string properties Eduardo Habkost
2014-08-07 2:24 ` Amos Kong
2014-09-04 15:25 ` Michael S. Tsirkin
2014-08-22 19:35 ` [Qemu-devel] [PATCH RESEND 0/2] Fix leaks on object_property_add_str() setters Eduardo Habkost
2014-08-24 11:16 ` Michael S. Tsirkin
2014-08-25 11:44 ` Paolo Bonzini
2014-09-04 15:08 ` Eduardo Habkost
2014-09-04 15:29 ` Michael S. Tsirkin
2014-09-04 15:31 ` Michael S. Tsirkin
2014-09-04 15:34 ` Eduardo Habkost
2014-09-04 16:11 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825155928.GA1925@zen \
--to=akong@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).