From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLwns-0000nv-0s for qemu-devel@nongnu.org; Mon, 25 Aug 2014 12:07:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLwnl-00053u-RP for qemu-devel@nongnu.org; Mon, 25 Aug 2014 12:07:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLwnl-00053l-Hx for qemu-devel@nongnu.org; Mon, 25 Aug 2014 12:07:25 -0400 Date: Tue, 26 Aug 2014 00:07:17 +0800 From: Amos Kong Message-ID: <20140825160717.GB1925@zen> References: <1408119832-4354-1-git-send-email-akong@redhat.com> <20140819144720.GA13680@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline In-Reply-To: <20140819144720.GA13680@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH] Revert "virtio_rng: replace custom backend API with UserCreatable.complete() callback" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , pbonzini@redhat.com Cc: imammedo@redhat.com, afaerber@suse.de, qemu-devel@nongnu.org, aliguori@amazon.com, lcapitulino@redhat.com --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 19, 2014 at 03:47:20PM +0100, Stefan Hajnoczi wrote: > On Sat, Aug 16, 2014 at 12:23:52AM +0800, Amos Kong wrote: > > This reverts commit 57d3e1b3f52d07d215ed96df946ee01f8d9f9526. > >=20 > > The commit introduced a regression bug, the initialization order of vir= tio-rng > > backend was changed. > >=20 > > # x86_64-softmmu/qemu-system-x86_64 -monitor stdio -vnc :0 \ > > -chardev socket,host=3Dlocalhost,port=3D1024,id=3Dchr0 \ > > -object rng-egd,chardev=3Dchr0,id=3Drng0 Paolo posted a new patch [1] to fix this bug, above commandline works. > > qemu-system-x86_64: -object rng-egd,chardev=3Dchr0,id=3Drng0: Device '= chr0' not found > >=20 > > Chardev 'chr0' isn't initialized when we try to open rng backend, >=20 > More detail: > The problem is that vl.c:main() calls object_create() on -object before > -chardev options are processed. Moving the object_create() call after > chardev is arbitrary and does not work if a chardev depends on an > -object. Stefan, can you give an example of the complex relying? So Paolo's patch ca= n't solve this problem? =20 > It would have been nice to process command-line options in left-to-right > order instead of grouping them by option type. I doubt we can change > this now since it would break the command-line. >=20 > > Conflicts: > > hw/virtio/virtio-rng.c >=20 > This shouldn't be here. >=20 > I agree with reverting commit 57d3e1b3f52d07d215ed96df946ee01f8d9f9526. --=20 Amos. --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT+181AAoJELxSv6I5vP9jyPsP/2G0NZgrGtMSHfmUYZRxvDlr mh2yAOop/tCoFzaYm+/qn0gzqxaPABa8C48c5+HDvkiR+gkc+8x5ktG0tpXayNfp eHi22NBsLb27d3H+5oEPYyOONobBG+8B3YCMJoQdGkeqT7ZIlVvyMpNPs5Ijawor aDJbQuSQykCIZE4v28mZPb+OvxlXVEjdZC/83ZX9CWFVoZ+ukRWKxUy+ae5rFF9p 40FIij3H7KvgGAKcYkWOksbqAfDHMeyC5RFenroEu6uQVghUCTFFrABYoNzWq6G2 CVBqgIHKtNgmtK70KjMTFVfxnHg3EF01aIePvYmKobQz/+rezBw2ldOVr5d5JiEC p5ORoibgEhXmpXoXUf21oJfA085mQFmyINmdX1GBNkRod+FZVDmaUZ6az4fdi8jC PXfWXC7En/F9dr3w831Q5mHaVeN9RCsbi0GF0tPezx90V8fjCMPP1a9gTocD9o0y x7rmz0OybWNMXuS2CSENjgpo9Q0UEKaJfOmBdeItsP7estecshuPcB1mZvwjF/Vn X1c7uJnUU2OYgjtwc2xVfZjVy3ENs1Vsj8MQia4qMF2EKzY7m+lIpszy4h0tDin+ 2Vksj0mFHfi6g0LC1NP+ts0FZeBZSWstt/0mqzIXJ6ZJfAXnlFd4+OUb9bwXd1K7 X+Sw+/CwVeJNwsBH/DCM =D4B5 -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l--