From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XM5jK-0007Vt-Fk for qemu-devel@nongnu.org; Mon, 25 Aug 2014 21:39:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XM5jF-0005kD-Al for qemu-devel@nongnu.org; Mon, 25 Aug 2014 21:39:26 -0400 Date: Tue, 26 Aug 2014 10:32:18 +1000 From: David Gibson Message-ID: <20140826003218.GC9923@voom.redhat.com> References: <1407869623-11185-1-git-send-email-tommusta@gmail.com> <1407869623-11185-3-git-send-email-tommusta@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5G06lTa6Jq83wMTw" Content-Disposition: inline In-Reply-To: <1407869623-11185-3-git-send-email-tommusta@gmail.com> Subject: Re: [Qemu-devel] [V2 PATCH 02/12] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta Cc: peter.maydell@linaro.org, riku.voipio@linaro.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --5G06lTa6Jq83wMTw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 12, 2014 at 01:53:33PM -0500, Tom Musta wrote: > When the ipc system call is used to wrap a semctl system call, > the ptr argument to ipc needs to be dereferenced prior to passing > it to the semctl handler. This is because the fourth argument to > semctl is a union and not a pointer to a union. >=20 > Signed-off-by: Tom Musta > --- >=20 > V2: This is unchanged from V1. I briefly reviewew the QEMU, glibc and k= ernel code > looking for some problems but did not find anything. I also did fairly c= omprehesive > testing of semctl on 4 targets (ppc-linux-user, ppc64-linux-user, ppc64le= -linux-user, > x86_64-linux-user) on 3 different host platforms (x86-64 Ubuntu, PPC64 RH= EL 6 (BE) and > PPC64 Ubuntu 14.04 (LE)); this provided a broad coverage of co-endian and= cross endian > situations. Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --5G06lTa6Jq83wMTw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT+9WSAAoJEGw4ysog2bOSPgwQAKxVNvoGcsS9ifV0gZ5QzrnO yhLpu4sgHTbvMtNazqpmrjCnsWCgoIUTvMYSzBTNkkm3izDHWKmkpX4H9/XeA80X w/bdPbRDvBlYc/OOOp7eeDdsUgx6LYQPnslJePTYcRvOHl9inbAbgrMxV6mNBI2J FSnR6SfPAsz+kxCwo0s8O43T/F8+zaEmnihacYxY+0keNhMky7gkSTxfyztSW9TX mEjbAvUqLN5o3sJFPQwDI3DzHmum1y7fW6U0EjdyfJtdanLA6/8wsGJ5dLx79obX zszhXpJ5mQ7tpswfO/ZYTy5K0bdm2xLVctO/G8vMbRaQiKEn6HPIsja/Ncv+f8hM Je7lqG6mqUfnKau7vouDcHMdO/SWoVSo1r0BYZdj4wMQRyBm9kRuLciZ0OCtIQlO xFDuk4++8MEl/4spaEVGJ6FonY+p9KIdNg1E9OvlK2T+9UYK6PHeSfR+O2Z+nhNm fOhbRHFiloUSbVpRBukc6v3YBpGUrjGcd7Fkpr5r12r27QEIiLqsbgBNHNuChPqf C18eP/TVFWPdYc7QziGdSpMqSLJaJuu7N7dOXuEjnoetsN86zLmjCr1lg/5jURs9 FAH4d3MesZSrxn/fw+jHfJJviV4n+KsV4FQV47xfMgrffnXYUAgu76WIxJrqjc4d 20mQ/b8xG2s8HCy94yfA =i961 -----END PGP SIGNATURE----- --5G06lTa6Jq83wMTw--