From: David Gibson <david@gibson.dropbear.id.au>
To: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>
Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V5] spapr: Fix stale HTAB during live migration
Date: Tue, 26 Aug 2014 13:01:19 +1000 [thread overview]
Message-ID: <20140826030119.GM9923@voom.redhat.com> (raw)
In-Reply-To: <1408667050-10789-1-git-send-email-sam.mj@au1.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Fri, Aug 22, 2014 at 10:24:10AM +1000, Samuel Mendoza-Jonas wrote:
> If a guest reboots during a running migration, changes to the
> hash page table are not necessarily updated on the destination.
> Opening a new file descriptor to the HTAB forces the migration
> handler to resend the entire table.
Of course, arguably this is a kernel bug - the htab fd should probably
start re-reporting things if the htab reset ioctl() is called. But I
guess we need a workaround for existing kernels anyway.
However, don't we still have the bug for TCG mode? spapr_reset_htab()
just memset()s the whole hashtable in that case, which will actually
clear all the dirty bits, whereas we need to set them.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-26 3:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 0:24 [Qemu-devel] [PATCH V5] spapr: Fix stale HTAB during live migration Samuel Mendoza-Jonas
2014-08-26 3:01 ` David Gibson [this message]
2014-08-26 3:40 ` Sam Mendoza-Jonas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826030119.GM9923@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sam.mj@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).