From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMB7H-0001gJ-Bb for qemu-devel@nongnu.org; Tue, 26 Aug 2014 03:24:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMB7D-0007ep-4Q for qemu-devel@nongnu.org; Tue, 26 Aug 2014 03:24:31 -0400 Date: Tue, 26 Aug 2014 17:24:14 +1000 From: David Gibson Message-ID: <20140826072414.GZ9923@voom.redhat.com> References: <20140825134353.2361.52046.stgit@aravindap> <20140825134516.2361.32987.stgit@aravindap> <20140826053802.GO9923@voom.redhat.com> <53FC2A73.1000200@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="L4xCDQ7GT+ph8Lmk" Content-Disposition: inline In-Reply-To: <53FC2A73.1000200@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aravinda Prasad Cc: qemu-ppc@nongnu.org, benh@au1.ibm.com, aik@au1.ibm.com, qemu-devel@nongnu.org, paulus@samba.org --L4xCDQ7GT+ph8Lmk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 26, 2014 at 12:04:27PM +0530, Aravinda Prasad wrote: >=20 >=20 > On Tuesday 26 August 2014 11:08 AM, David Gibson wrote: > > On Mon, Aug 25, 2014 at 07:15:16PM +0530, Aravinda Prasad wrote: > >> Extend rtas-blob to accommodate error log. Error log > >> structure is saved in rtas space upon a machine check > >> exception. > >=20 > > Hrm. Putting the reserved space into the actual firmware image file > > seems really clumsy to me. Wouldn't it be better to reserve the space > > directly from qemu, then just paste the 20 bytes of code into that > > area. >=20 > Hmm. It is possible to it from qemu. In that case we can get rid of > spapr-rtas.S. Let me think about that. I think getting rid of spapr-rtas.S is probably a good idea. It complicates building things for the sake of 5 instructions. Especially since in your new code you construct the vector instructions directly, it makes sense to do the same thing for spapr-rtas. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --L4xCDQ7GT+ph8Lmk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT/DYeAAoJEGw4ysog2bOSWiwP/i3WB1hPquEhbAmw1iIIoi6P maJozKAnr31U0bcbMTB3nEqcDmPecVpLuH9ICroZhyFdhKmRLjr6FFbisDqiuB5u KMkAwhbBACCaNz5ZfzPUZSif4mKmmCWyT6V9uQEWAekkRNjz5mBxe5wDi/TDvXeO f4ZkLT922PdyUVlneFS4wvvXtKKZyFOjwSWmyUOSOZKNmaT8pGpfPguJWMcBXk1U H5OjurcQZX2Wgo7o8aw4Yigyj2E48/A76WS/qZTbae4JYvHp5AJiHxe9T+VQvi9B E3Ya3vH0gKvA1WQAY/Zf3Uw3CGdLgZ0I5jPr8Ss4J5rQBLiQM6e/p+Ybx5BB9Pp4 lBapf2CFm9sH8p9vjddcgnmwW0lJi68Zhj4uoHzlvH7du7WFAoDMeEKEb1SG1B29 TmOtNjaFFZsVTh31Gn5jRdukXTUwH4ooEG0wpm/vdjO2CrP7pwC1i8H1g6T3DQq1 5Mesnivc5600uX4bfzwXzbaKO8GVJRR7vaGgzKxeVXGXUSowTvg8Y2NZPuj5Dy/H z0zQb3k9yhheI2MddovDR+hJiQA/c5ZSz/ANk9NTAxPNSK9/pvJ6dWOJl3DanBmj 6UC48MvVL+PTItzopjZJAO5StFzFipYmbpaoBAsQThafIAwz4igoumVK93Ys9ziF 3QQA2gSqCrDbKoyYMvkI =euO4 -----END PGP SIGNATURE----- --L4xCDQ7GT+ph8Lmk--