From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Benoit Canet <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH v4 2/5] qtest: Add scripts/qtest/qtest.py
Date: Tue, 26 Aug 2014 14:21:59 +0100 [thread overview]
Message-ID: <20140826132159.GE11279@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1401958066-22118-3-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On Thu, Jun 05, 2014 at 04:47:43PM +0800, Fam Zheng wrote:
> diff --git a/scripts/qtest b/scripts/qtest
> deleted file mode 100755
> index 4ef6c1c..0000000
> --- a/scripts/qtest
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -#!/bin/sh
> -
> -export QTEST_QEMU_BINARY=$1
> -shift
> -"$@"
Why delete this? The script is unrelated to qtest.py.
I think nothing uses scripts/qtest so it could be deleted in a separate
commit if you feel that is worthwhile.
> +import errno
> +import socket
> +
> +class QEMUQtestProtocol:
Using new-style classes is probably a good idea:
class QEMUQtestProtocol(object):
https://docs.python.org/2.7/reference/datamodel.html#newstyle
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-08-26 13:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 8:47 [Qemu-devel] [PATCH v4 0/5] This series adds iotest case for IO throttling Fam Zheng
2014-06-05 8:47 ` [Qemu-devel] [PATCH v4 1/5] qemu-io: Account IO by aio_read and aio_write Fam Zheng
2014-06-05 8:47 ` [Qemu-devel] [PATCH v4 2/5] qtest: Add scripts/qtest/qtest.py Fam Zheng
2014-08-26 13:21 ` Stefan Hajnoczi [this message]
2014-08-27 3:12 ` Fam Zheng
2014-06-05 8:47 ` [Qemu-devel] [PATCH v4 3/5] qemu-iotests: Add VM method qtest() to iotests.py Fam Zheng
2014-06-05 8:47 ` [Qemu-devel] [PATCH v4 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp Fam Zheng
2014-06-05 8:47 ` [Qemu-devel] [PATCH v4 5/5] qemu-iotests: Add 093 for IO throttling Fam Zheng
2014-08-26 13:50 ` Stefan Hajnoczi
2014-08-27 6:19 ` Fam Zheng
2014-08-27 8:46 ` Stefan Hajnoczi
2014-06-17 2:45 ` [Qemu-devel] [PATCH v4 0/5] This series adds iotest case " Fam Zheng
2014-07-31 7:29 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826132159.GE11279@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=benoit@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).