From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46324)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XMGhM-0007Sb-TF
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 09:22:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XMGhI-0005if-A2
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 09:22:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59953)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XMGhI-0005ia-2H
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 09:22:04 -0400
Date: Tue, 26 Aug 2014 14:21:59 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140826132159.GE11279@stefanha-thinkpad.redhat.com>
References: <1401958066-22118-1-git-send-email-famz@redhat.com>
	<1401958066-22118-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="FN+gV9K+162wdwwF"
Content-Disposition: inline
In-Reply-To: <1401958066-22118-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/5] qtest: Add scripts/qtest/qtest.py
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Benoit Canet <benoit@irqsave.net>


--FN+gV9K+162wdwwF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jun 05, 2014 at 04:47:43PM +0800, Fam Zheng wrote:
> diff --git a/scripts/qtest b/scripts/qtest
> deleted file mode 100755
> index 4ef6c1c..0000000
> --- a/scripts/qtest
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -#!/bin/sh
> -
> -export QTEST_QEMU_BINARY=$1
> -shift
> -"$@"

Why delete this?  The script is unrelated to qtest.py.

I think nothing uses scripts/qtest so it could be deleted in a separate
commit if you feel that is worthwhile.

> +import errno
> +import socket
> +
> +class QEMUQtestProtocol:

Using new-style classes is probably a good idea:

  class QEMUQtestProtocol(object):

https://docs.python.org/2.7/reference/datamodel.html#newstyle

--FN+gV9K+162wdwwF
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJT/In3AAoJEJykq7OBq3PIoSwH/14DMhnzm1VeNImeJ42nw/R5
KDYOG3tOM4xCvwoXySBhc8qMS6RWbRop8Xzg7DaQfkzhD0pBGBKZrlCQajlXx0dI
v6PqFbtdmP17FY5ivWLXsqSC3AOb7C0MEEfOtvdaT3zIH7gxd76hJm1+O4/wQPTj
I+eE63FvXN6TNraUtpUTlvpsJ6/yPB/8UmgbenPMfpWcJilDFmu6DVKs+amcreoR
wyPA7E8MLIImZkEs2Yg60JGusB/Ykdrd+Mqejr+8t09+ZrA/I9ELliuNV3BQHwjM
NPpAM6HKT8KepmRtPZVJ/uOqaeugcABSVWwNA92gS4RX/qMW5NjSUYd45YO7vz8=
=FFa7
-----END PGP SIGNATURE-----

--FN+gV9K+162wdwwF--