From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38161)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1XMNQ7-0001qQ-Eg
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 16:32:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1XMNQ2-0003PM-Q8
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 16:32:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10008)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1XMNQ2-0003PC-JQ
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 16:32:42 -0400
Date: Tue, 26 Aug 2014 21:32:37 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20140826203236.GL14001@redhat.com>
References: <1407944667-17932-1-git-send-email-danielhb@linux.vnet.ibm.com>
	<1407944667-17932-2-git-send-email-danielhb@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1407944667-17932-2-git-send-email-danielhb@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v3] block.curl: adding 'timeout' option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Qemu Devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On Wed, Aug 13, 2014 at 12:44:27PM -0300, Daniel Henrique Barboza wrote:
> The curl hardcoded timeout (5 seconds) sometimes is not long
> enough depending on the remote server configuration and network
> traffic. The user should be able to set how much long he is
> willing to wait for the connection.
> 
> Adding a new option to set this timeout gives the user this
> flexibility. The previous default timeout of 5 seconds will be
> used if this option is not present.
> 
> Reviewed-by: Fam Zheng <famz@redhat.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>

You can add:

Tested-by: Richard W.M. Jones <rjones@redhat.com>

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html