From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49756)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XMTf3-0002D0-L4
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 23:12:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XMTez-000439-2C
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 23:12:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XMTey-00041o-Qe
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 23:12:32 -0400
Date: Wed, 27 Aug 2014 11:12:45 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140827031245.GB2977@T430.nay.redhat.com>
References: <1401958066-22118-1-git-send-email-famz@redhat.com>
	<1401958066-22118-3-git-send-email-famz@redhat.com>
	<20140826132159.GE11279@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140826132159.GE11279@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/5] qtest: Add scripts/qtest/qtest.py
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Benoit Canet <benoit@irqsave.net>

On Tue, 08/26 14:21, Stefan Hajnoczi wrote:
> On Thu, Jun 05, 2014 at 04:47:43PM +0800, Fam Zheng wrote:
> > diff --git a/scripts/qtest b/scripts/qtest
> > deleted file mode 100755
> > index 4ef6c1c..0000000
> > --- a/scripts/qtest
> > +++ /dev/null
> > @@ -1,5 +0,0 @@
> > -#!/bin/sh
> > -
> > -export QTEST_QEMU_BINARY=$1
> > -shift
> > -"$@"
> 
> Why delete this?  The script is unrelated to qtest.py.
> 
> I think nothing uses scripts/qtest so it could be deleted in a separate
> commit if you feel that is worthwhile.

OK. I'll send a separate patch.

> 
> > +import errno
> > +import socket
> > +
> > +class QEMUQtestProtocol:
> 
> Using new-style classes is probably a good idea:
> 
>   class QEMUQtestProtocol(object):
> 
> https://docs.python.org/2.7/reference/datamodel.html#newstyle

OK.