From: David Gibson <david@gibson.dropbear.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies
Date: Wed, 27 Aug 2014 18:22:21 +1000 [thread overview]
Message-ID: <20140827082221.GA1930@voom.redhat.com> (raw)
In-Reply-To: <53FC4682.7030002@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On Tue, Aug 26, 2014 at 10:34:10AM +0200, Paolo Bonzini wrote:
> Il 26/08/2014 06:30, David Gibson ha scritto:
> > These 3 patches fix some places where things ought to depend on an
> > existing config variable, but don't.
>
> Which header provdides the #defines?
Ah, crap, none does. So effectively, my patch unconditionally
disables those tests.
Have I mentioned that I really hate the fact that qemu has different
config variables visible to make and C.
I'll rework, but probably not for a little while, since I have to
focus on some kernel work instead for the time being.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-27 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 4:30 [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies David Gibson
2014-08-26 4:30 ` [Qemu-devel] [PATCH 1/3] target-ppc: Disable PReP testcases with !CONFIG_PREP David Gibson
2014-08-26 4:30 ` [Qemu-devel] [PATCH 2/3] target-ppc: Disable ppc Mac tests when !CONFIG_MAC David Gibson
2014-08-26 4:30 ` [Qemu-devel] [PATCH 3/3] target-ppc: virtex-ml507 machine type should depend on CONFIG_XILINX David Gibson
2014-08-26 6:12 ` Peter Crosthwaite
2014-09-08 11:10 ` Alexander Graf
2014-08-26 8:34 ` [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies Paolo Bonzini
2014-08-27 8:22 ` David Gibson [this message]
2014-08-27 10:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827082221.GA1930@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).