From: "Richard W.M. Jones" <rjones@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com,
danielhb@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.
Date: Wed, 27 Aug 2014 11:16:15 +0100 [thread overview]
Message-ID: <20140827101614.GK1302@redhat.com> (raw)
In-Reply-To: <87mwaqfnfh.fsf@blackfin.pond.sub.org>
On Wed, Aug 27, 2014 at 08:37:22AM +0200, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
> > On 08/26/2014 08:38 PM, Fam Zheng wrote:
> >> On Tue, 08/26 21:48, Richard W.M. Jones wrote:
> >>> Some servers (notably VMware ESX) accept range requests, but don't
> >>> send back the Accept-Ranges: bytes header in their initial response.
> >>>
> >>> For these servers you can set override_accept_ranges to 'on' which
> >>> forces this block driver to send range requests anyway.
> >
> > Is this a case where we should be naming with dashes instead of
> > underscores, as in override-accept-ranges?
>
> Yes.
Thanks for reviewing. I'm actually going to drop this for a couple of
reasons:
- VMware vSphere does send the header, only ESX doesn't.
- When you access ESX (using this patch) eventually the ESX web
server crashes. In a sense ESX was correct that it doesn't support
ranges -- because it's buggy.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
next prev parent reply other threads:[~2014-08-27 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 20:48 [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range Richard W.M. Jones
2014-08-26 20:48 ` [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests Richard W.M. Jones
2014-08-27 2:38 ` Fam Zheng
2014-08-27 2:57 ` Eric Blake
2014-08-27 6:37 ` Markus Armbruster
2014-08-27 10:16 ` Richard W.M. Jones [this message]
2014-08-27 7:57 ` Richard W.M. Jones
2014-08-27 12:51 ` Daniel H Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827101614.GK1302@redhat.com \
--to=rjones@redhat.com \
--cc=armbru@redhat.com \
--cc=danielhb@linux.vnet.ibm.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).