From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMaHB-0007wv-0F for qemu-devel@nongnu.org; Wed, 27 Aug 2014 06:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMaH6-0007N5-87 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 06:16:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMaH6-0007Mw-1P for qemu-devel@nongnu.org; Wed, 27 Aug 2014 06:16:20 -0400 Date: Wed, 27 Aug 2014 11:16:15 +0100 From: "Richard W.M. Jones" Message-ID: <20140827101614.GK1302@redhat.com> References: <1409086088-20910-1-git-send-email-rjones@redhat.com> <1409086088-20910-2-git-send-email-rjones@redhat.com> <20140827023845.GA2977@T430.nay.redhat.com> <53FD491A.9060303@redhat.com> <87mwaqfnfh.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mwaqfnfh.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, Fam Zheng , qemu-devel@nongnu.org, stefanha@redhat.com, danielhb@linux.vnet.ibm.com On Wed, Aug 27, 2014 at 08:37:22AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 08/26/2014 08:38 PM, Fam Zheng wrote: > >> On Tue, 08/26 21:48, Richard W.M. Jones wrote: > >>> Some servers (notably VMware ESX) accept range requests, but don't > >>> send back the Accept-Ranges: bytes header in their initial response. > >>> > >>> For these servers you can set override_accept_ranges to 'on' which > >>> forces this block driver to send range requests anyway. > > > > Is this a case where we should be naming with dashes instead of > > underscores, as in override-accept-ranges? > > Yes. Thanks for reviewing. I'm actually going to drop this for a couple of reasons: - VMware vSphere does send the header, only ESX doesn't. - When you access ESX (using this patch) eventually the ESX web server crashes. In a sense ESX was correct that it doesn't support ranges -- because it's buggy. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org