From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMayt-0006Hz-9x for qemu-devel@nongnu.org; Wed, 27 Aug 2014 07:01:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMaym-0003QZ-VN for qemu-devel@nongnu.org; Wed, 27 Aug 2014 07:01:35 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:33246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMaym-0003QN-9l for qemu-devel@nongnu.org; Wed, 27 Aug 2014 07:01:28 -0400 Received: by mail-we0-f176.google.com with SMTP id q58so36752wes.35 for ; Wed, 27 Aug 2014 04:01:24 -0700 (PDT) Date: Wed, 27 Aug 2014 12:01:16 +0100 From: Stefan Hajnoczi Message-ID: <20140827110116.GE8280@stefanha-thinkpad.redhat.com> References: <1407847054-672-1-git-send-email-stefanha@redhat.com> <1407847054-672-2-git-send-email-stefanha@redhat.com> <20140815074324.GA17962@afflict.kos.to> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X3gaHHMYHkYqP6yf" Content-Disposition: inline In-Reply-To: <20140815074324.GA17962@afflict.kos.to> Subject: Re: [Qemu-devel] [PATCH 1/2] qapi.py: avoid Python 2.5+ any() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Riku Voipio Cc: Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi , Andreas Faerber --X3gaHHMYHkYqP6yf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 15, 2014 at 10:43:24AM +0300, Riku Voipio wrote: > On Tue, Aug 12, 2014 at 01:37:33PM +0100, Stefan Hajnoczi wrote: > > There is one instance of any() in qapi.py that breaks builds on older > > distros that ship Python 2.4 (like RHEL5): > >=20 > > GEN qmp-commands.h > > Traceback (most recent call last): > > File "build/scripts/qapi-commands.py", line 445, in ? > > exprs =3D parse_schema(input_file) > > File "build/scripts/qapi.py", line 329, in parse_schema > > schema =3D QAPISchema(open(input_file, "r")) > > File "build/scripts/qapi.py", line 110, in __init__ > > if any(include_path =3D=3D elem[1] > > NameError: global name 'any' is not defined >=20 > I tried building on RHEL5, and this patch gets a bit more forward. > However further down the build I get a similar error: >=20 > Traceback (most recent call last): > File "/build/qemu/scripts/tracetool.py", line 139, in ? > main(sys.argv) > File "/build/qemu/scripts/tracetool.py", line 134, in main > binary=3Dbinary, probe_prefix=3Dprobe_prefix) > File "/build/qemu/scripts/tracetool/__init__.py", line 267, in generate > backend =3D tracetool.backend.Wrapper(backends, format) > File "/build/qemu/scripts/tracetool/backend/__init__.py", line 105, in = __init__ > assert all(exists(backend) for backend in self._backends) >=20 > semi-related - since I'm building --disable-system --disable-tools --enab= le-user, > is there any benefit of tracetool for this build config? I will send a new revision with additional fixes. --X3gaHHMYHkYqP6yf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT/bp8AAoJEJykq7OBq3PI6GQH/1EfLpVmhiPwBQ8/RNh3A0ZP 6hsxJ+UGHLHyVK3Jw1zc4Gx/NaFwYUwV5JxUYHpRwNx+KVUxTXn9T5k/4gXVt9CV MzzaWJ6c0an+AgKxJVI6sFnZoxghA8yzdjrIJ0q5iJyB+F2+xcmwg8RtAZwo6nNa 36eCUfa6RnEAZirnEZLJ+aVR4jLt3x4thnD/SSGkuudNUbRhi8jvUgFGCHx5Nec6 FnigGnq+/BGAum4gTQt1X99qj9zvxM4S/tyYWik6W/Dk5i4lzRBNrsLN6W5lkbET kzPLdsDmBQjGlfJocjfrVub7kcUNd1MsuaLIB8PLSyXQsJvPf8PV1TbUGdFltn4= =hEe7 -----END PGP SIGNATURE----- --X3gaHHMYHkYqP6yf--