From: Stefan Hajnoczi <stefanha@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] bad error message in drive-mirror
Date: Wed, 27 Aug 2014 14:30:28 +0100 [thread overview]
Message-ID: <20140827133028.GJ8280@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <53FBC627.1000209@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Mon, Aug 25, 2014 at 05:26:31PM -0600, Eric Blake wrote:
> I just noticed today that passing "granularity":1 to QMP drive-mirror
> results in this confusing error message:
>
> Invalid parameter 'drive-virtio-disk0'
>
> because the code mistakenly did
> error_set(errp, QERR_INVALID_PARAMETER, device);
> instead of the correct
> error_set(errp, QERR_INVALID_PARAMETER, "granularity");
>
> I ran out of time to patch it today, and at any rate, whoever writes the
> patch should probably audit for other bad uses of
> error_set(QERR_INVALID_PARAMETER).
I have sent a patch to fix this. Thanks for reporting it.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-08-27 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 23:26 [Qemu-devel] bad error message in drive-mirror Eric Blake
2014-08-27 13:30 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827133028.GJ8280@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).