From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMdJJ-0003M4-E9 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:30:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMdJ6-0005c7-FY for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:30:49 -0400 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:43409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMdJ6-0005c3-8z for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:30:36 -0400 Received: by mail-we0-f181.google.com with SMTP id k48so222695wev.12 for ; Wed, 27 Aug 2014 06:30:32 -0700 (PDT) Date: Wed, 27 Aug 2014 14:30:28 +0100 From: Stefan Hajnoczi Message-ID: <20140827133028.GJ8280@stefanha-thinkpad.redhat.com> References: <53FBC627.1000209@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hk6Zb6cduJ+I0Tmj" Content-Disposition: inline In-Reply-To: <53FBC627.1000209@redhat.com> Subject: Re: [Qemu-devel] bad error message in drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Luiz Capitulino , "qemu-devel@nongnu.org" , Markus Armbruster --hk6Zb6cduJ+I0Tmj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 25, 2014 at 05:26:31PM -0600, Eric Blake wrote: > I just noticed today that passing "granularity":1 to QMP drive-mirror > results in this confusing error message: >=20 > Invalid parameter 'drive-virtio-disk0' >=20 > because the code mistakenly did > error_set(errp, QERR_INVALID_PARAMETER, device); > instead of the correct > error_set(errp, QERR_INVALID_PARAMETER, "granularity"); >=20 > I ran out of time to patch it today, and at any rate, whoever writes the > patch should probably audit for other bad uses of > error_set(QERR_INVALID_PARAMETER). I have sent a patch to fix this. Thanks for reporting it. Stefan --hk6Zb6cduJ+I0Tmj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT/d10AAoJEJykq7OBq3PI25YIALZ5cXM8Qglyv51g+2DAJsEv te1VrJNIhXJ9QUjNqcfeNRo5VbpwLuAnp8QG/GtlWt+xB5s/t2G5GcRhe6BdJ43f RwS7HTzSRe4ZpkciRrpnQFE8YwpVNJSPcZ56kXI4etSkjmssvoCgYr3ikfNS1FwH qeCD/xVdSi0GYQilMD6yUa192ujUnfQgauUYP9hlPl/DovyzcDkJByZKVqN2xvq1 SMqeOiZUlV5HMLyW8sIe1TzPFu/QX/XiNetA8ZToCqeX9oozMxonUgG85uqLn16z wz+dX9aqA2eBNgvyusUFXSKtXMjvDSRJM4jzO32FIpxBPD7qK0rT4JMf+hjL1L4= =GsSF -----END PGP SIGNATURE----- --hk6Zb6cduJ+I0Tmj--