From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMdMc-0006S3-Ku for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:34:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMdMW-0006Il-N7 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:34:14 -0400 Date: Wed, 27 Aug 2014 14:34:00 +0100 From: Stefan Hajnoczi Message-ID: <20140827133400.GK8280@stefanha-thinkpad.redhat.com> References: <1408969024-22548-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Rex5+51txc1ort/q" Content-Disposition: inline In-Reply-To: <1408969024-22548-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] vl: process -object after other backend options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: imammedo@redhat.com, akong@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org --Rex5+51txc1ort/q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 25, 2014 at 02:17:04PM +0200, Paolo Bonzini wrote: > QOM backends can refer to chardevs, but not vice versa. So > process -chardev and -fsdev options before -object >=20 > This fixes the rng-egd backend to virtio-rng. >=20 > Reported-by: Amos Kong > Cc: qemu-stable@nongnu.org > Signed-off-by: Paolo Bonzini > --- > vl.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Option ordering is a bad idea. With an option as generic as -object, who can say that there will never be a non-object that depends on an -object? We should process the command-line left-to-right instead of ordering by option type. Maybe that would be a good QEMU 3.0 feature! :) Feel free to merge if it works for now, but we'll need a better fix in the future. Stefan --Rex5+51txc1ort/q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT/d5IAAoJEJykq7OBq3PIktcH/1dDzf40evL5deufaAxdHZKI rRTuZCK/ouh+oTkRXigZbSZ82fAFf3ggg05hjZzvccN9gTkl+8L+A4XJ9cja3eir bioiMNNoLWKaDMrkB3DuaSXjhVUgfCZUa4mc7WE7LtnphJlJ3J5YtW5NGA29MIDZ vFCvHd1agInwgI6fk/CIiOU1xfDeO7yl06IU1ypUDaDNqyY6ioPTbg8QMKIxGWUD SfN13Uwm0LXH2eije/dJ9X52DCAEy+eOgDl5toiA1UqwWe6g25LZKfu3mAlfFYJs 64uqgme7+xAouLs8P3ex/B0qUbzHg3+isZfeLS8D7u4qg0zchXbeVPJXdKNKgQk= =Vzel -----END PGP SIGNATURE----- --Rex5+51txc1ort/q--