From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36219)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XMddE-0005S2-2J
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:51:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XMdd5-0003OS-1U
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:51:24 -0400
Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:37061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XMdd4-0003OH-QX
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:51:14 -0400
Received: by mail-we0-f171.google.com with SMTP id p10so253805wes.30
	for <qemu-devel@nongnu.org>; Wed, 27 Aug 2014 06:51:13 -0700 (PDT)
Date: Wed, 27 Aug 2014 14:51:10 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140827135110.GL8280@stefanha-thinkpad.redhat.com>
References: <1408955773-4778-1-git-send-email-marc.mari.barcelo@gmail.com>
	<1408955773-4778-3-git-send-email-marc.mari.barcelo@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="dfmC41YZQlborXoK"
Content-Disposition: inline
In-Reply-To: <1408955773-4778-3-git-send-email-marc.mari.barcelo@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v6 2/7] tests: Add virtio device
 initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marc =?iso-8859-1?Q?Mar=ED?= <marc.mari.barcelo@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>


--dfmC41YZQlborXoK
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 25, 2014 at 10:36:08AM +0200, Marc Mar=ED wrote:
> +static uint16_t qvirtio_pci_config_readw(QVirtioDevice *d, void *addr)
> +{
> +    QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d;
> +    return qpci_io_readw(dev->pdev, addr);
> +}
> +
> +static uint32_t qvirtio_pci_config_readl(QVirtioDevice *d, void *addr)
> +{
> +    QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d;
> +    return qpci_io_readl(dev->pdev, addr);
> +}
> +
> +static uint64_t qvirtio_pci_config_readq(QVirtioDevice *d, void *addr)
> +{
> +    QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d;
> +    int i;
> +    union {
> +        uint8_t bytes[8];
> +        uint64_t u64;
> +    } quad;
> +
> +    for (i =3D 0; i < 8; ++i) {
> +        quad.bytes[i] =3D qpci_io_readb(dev->pdev, addr + i);
> +    }
> +
> +    return quad.u64;
> +}

readw and readl are in host CPU endianness.

readq is in guest CPU endianness.

Please use qtest readq so that endianness is consistent.

--dfmC41YZQlborXoK
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJT/eJOAAoJEJykq7OBq3PISB4H/i74g17G8s/8Z2s/4keXDk+k
5BivOvdE4DY5LjsDeVRQOvsGKDvBp1e1n21Hhe4fa0HfNMrqKySJNzn1/vOWDDtC
vuy5uQqht6LLqvgIvqylcg4UyZ221pN1w5ZHt9EEtYV0aLcXOIgMNE0T2dU6DJuP
LhJ6zxxG2CeibkCgEPzj33xC6vkvFvOD/kKUdJuGeK9RIOrMsg/28EuLtC3U9fh+
Lb5Oi6lCc0uvTHW0ennTrloocnq+gD67Mct2zjMmA1iP1mKcgo9/A0/+V2UH1Q1b
ap7e0WwyW99N3OQNHEVAuYqFfV9waGcUcgEKrNlKKNB5VqxOKs5Z+S3DBhlhvyo=
=Yrlj
-----END PGP SIGNATURE-----

--dfmC41YZQlborXoK--