From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMdlD-0001n2-Uy for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMdl6-00062d-0J for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:59:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMdl5-00062Y-QM for qemu-devel@nongnu.org; Wed, 27 Aug 2014 09:59:31 -0400 Date: Wed, 27 Aug 2014 15:59:53 +0200 From: "Michael S. Tsirkin" Message-ID: <20140827135953.GA18634@redhat.com> References: <1408610249-7452-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408610249-7452-1-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit of FADT flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: huangzhichao , imammedo@redhat.com, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com On Thu, Aug 21, 2014 at 04:37:29PM +0800, zhanghailiang wrote: > If we start Windows 2008 R2 DataCenter with number of cpu less than 8, > The system will use APIC Flat Logical destination mode as default configuration, > Which has an upper limit of 8 CPUs. > > The fault is that VM can not show all processors within Task Manager if > we hot-add cpus when the number of cpus in VM extends the limit of 8. > > If we use cluster destination model, the problem will be solved. > > Signed-off-by: huangzhichao > Signed-off-by: zhanghailiang What if maxcpus is low? No reason to force cluster model then, right? > --- > hw/i386/acpi-build.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 10b84d0..fed4501 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -545,7 +545,8 @@ static void fadt_setup(AcpiFadtDescriptorRev1 *fadt, AcpiPmInfo *pm) > (1 << ACPI_FADT_F_PROC_C1) | > (1 << ACPI_FADT_F_SLP_BUTTON) | > (1 << ACPI_FADT_F_RTC_S4)); > - fadt->flags |= cpu_to_le32(1 << ACPI_FADT_F_USE_PLATFORM_CLOCK); > + fadt->flags |= cpu_to_le32(1 << ACPI_FADT_F_USE_PLATFORM_CLOCK | > + 1 << ACPI_FADT_F_FORCE_APIC_CLUSTER_MODEL); > } > > > -- > 1.7.12.4 >