From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45011)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XMe2U-0007s5-W0
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:17:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XMe2M-00046t-Od
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:17:30 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:38048 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XMe2M-00046m-Ho
	for qemu-devel@nongnu.org; Wed, 27 Aug 2014 10:17:22 -0400
Date: Wed, 27 Aug 2014 16:16:35 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140827141634.GC31176@irqsave.net>
References: <1409137736-827-1-git-send-email-stefanha@redhat.com>
	<1409137736-827-4-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1409137736-827-4-git-send-email-stefanha@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in
 tracetool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Andreas Faerber <afaerber@suse.de>

The Wednesday 27 Aug 2014 =E0 12:08:53 (+0100), Stefan Hajnoczi wrote :
> Red Hat Enterprise Linux 5 ships Python 2.4.3.  The all() function was
> added in Python 2.5 so we cannot use it.
>=20
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  scripts/tracetool/backend/__init__.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/scripts/tracetool/backend/__init__.py b/scripts/tracetool/=
backend/__init__.py
> index 5bfa1ef..d4b6dab 100644
> --- a/scripts/tracetool/backend/__init__.py
> +++ b/scripts/tracetool/backend/__init__.py
> @@ -102,7 +102,8 @@ class Wrapper:
>      def __init__(self, backends, format):
>          self._backends =3D [backend.replace("-", "_") for backend in b=
ackends]
>          self._format =3D format.replace("-", "_")
> -        assert all(exists(backend) for backend in self._backends)
> +        for backend in self._backends:
> +            assert exists(backend)
>          assert tracetool.format.exists(self._format)
> =20
>      def _run_function(self, name, *args, **kwargs):
> --=20
> 1.9.3
>=20
>=20
Reviewed-by: Beno=EEt Canet <benoit.canet@nodalink.com>