qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] glusterfs: do not log to stdout if daemonized
@ 2014-08-22 11:57 Dietmar Maurer
  2014-08-27 15:11 ` Stefan Hajnoczi
  0 siblings, 1 reply; 2+ messages in thread
From: Dietmar Maurer @ 2014-08-22 11:57 UTC (permalink / raw)
  To: qemu-devel@nongnu.org

Else stdout is not closed correctly.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>

Index: new/block/gluster.c
===================================================================
--- new.orig/block/gluster.c	2014-08-22 13:21:39.000000000 +0200
+++ new/block/gluster.c	2014-08-22 13:25:18.000000000 +0200
@@ -196,9 +196,11 @@
      * TODO: Use GF_LOG_ERROR instead of hard code value of 4 here when
      * GlusterFS makes GF_LOG_* macros available to libgfapi users.
      */
-    ret = glfs_set_logging(glfs, "-", 4);
-    if (ret < 0) {
-        goto out;
+    if (!is_daemonized()) {
+        ret = glfs_set_logging(glfs, "-", 4);
+        if (ret < 0) {
+            goto out;
+        }
     }
 
     ret = glfs_init(glfs);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-27 15:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 11:57 [Qemu-devel] glusterfs: do not log to stdout if daemonized Dietmar Maurer
2014-08-27 15:11 ` Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).