qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open
Date: Thu, 28 Aug 2014 12:06:12 +0800	[thread overview]
Message-ID: <20140828040612.GE15156@T430.redhat.com> (raw)
In-Reply-To: <53FE1822.5040407@redhat.com>

On Wed, 08/27 19:40, Max Reitz wrote:
> On 27.08.2014 08:02, Fam Zheng wrote:
> >Not all the error paths release opts, fix it by moving it after the fail
> >label.
> >
> >Signed-off-by: Fam Zheng <famz@redhat.com>
> >---
> >  block/qcow2.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> This is pretty much the same patch as 'qcow2: Fix leak of QemuOpts in
> qcow2_open()' from my 'qapi/block-core: Add "new" qcow2 options' series. I
> guess it's up to the maintainer(s) which one gets pulled, I just want to
> point out that pulling one means leaving out the other.

Since I need to respin this series, I will drop this one and leave it for your
series.

Thanks for pointing out. :)

Fam

      reply	other threads:[~2014-08-28  4:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  6:02 [Qemu-devel] [PATCH 0/4] block: Fix leaks of opts in block drivers Fam Zheng
2014-08-27  6:02 ` [Qemu-devel] [PATCH 1/4] nfs: Fix leak of opts in nfs_file_open Fam Zheng
2014-08-27 14:46   ` Benoît Canet
2014-08-28  4:07     ` Fam Zheng
2014-08-27  6:02 ` [Qemu-devel] [PATCH 2/4] blkverify: Fix leak of opts in blkverify_open Fam Zheng
2014-08-27 14:41   ` Benoît Canet
2014-08-27  6:02 ` [Qemu-devel] [PATCH 3/4] quorum: Fix leak of opts in quorum_open Fam Zheng
2014-08-27 14:36   ` Benoît Canet
2014-08-27  6:02 ` [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open Fam Zheng
2014-08-27 14:40   ` Benoît Canet
2014-08-28  4:04     ` Fam Zheng
2014-08-27 17:40   ` Max Reitz
2014-08-28  4:06     ` Fam Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140828040612.GE15156@T430.redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).