From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XMqyM-0005O0-6H
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 00:06:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XMqyF-0006wn-FQ
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 00:06:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XMqyF-0006wh-7O
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 00:05:59 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7S45v3w003640
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 28 Aug 2014 00:05:57 -0400
Date: Thu, 28 Aug 2014 12:06:12 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140828040612.GE15156@T430.redhat.com>
References: <1409119356-22742-1-git-send-email-famz@redhat.com>
	<1409119356-22742-5-git-send-email-famz@redhat.com>
	<53FE1822.5040407@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53FE1822.5040407@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] qcow2: Fix leak of opts in qcow2_open
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Wed, 08/27 19:40, Max Reitz wrote:
> On 27.08.2014 08:02, Fam Zheng wrote:
> >Not all the error paths release opts, fix it by moving it after the fail
> >label.
> >
> >Signed-off-by: Fam Zheng <famz@redhat.com>
> >---
> >  block/qcow2.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> This is pretty much the same patch as 'qcow2: Fix leak of QemuOpts in
> qcow2_open()' from my 'qapi/block-core: Add "new" qcow2 options' series. I
> guess it's up to the maintainer(s) which one gets pulled, I just want to
> point out that pulling one means leaving out the other.

Since I need to respin this series, I will drop this one and leave it for your
series.

Thanks for pointing out. :)

Fam