qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, zealot351@gmail.com,
	maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru
Subject: [Qemu-devel] [PATCH v2 02/12] pcspk: adding vmstate for save/restore
Date: Thu, 28 Aug 2014 15:18:35 +0400	[thread overview]
Message-ID: <20140828111835.1624.21791.stgit@PASHA-ISP> (raw)
In-Reply-To: <20140828111822.1624.24556.stgit@PASHA-ISP>

VMState added by this patch preserves correct
loading of the PC speaker device state.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 hw/audio/pcspk.c |   17 +++++++++++++++--
 1 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
index 1d81bbe..1d58ef0 100644
--- a/hw/audio/pcspk.c
+++ b/hw/audio/pcspk.c
@@ -50,8 +50,8 @@ typedef struct {
     unsigned int pit_count;
     unsigned int samples;
     unsigned int play_pos;
-    int data_on;
-    int dummy_refresh_clock;
+    uint8_t data_on;
+    uint8_t dummy_refresh_clock;
 } PCSpkState;
 
 static const char *s_spk = "pcspk";
@@ -163,6 +163,18 @@ static const MemoryRegionOps pcspk_io_ops = {
     },
 };
 
+static const VMStateDescription vmstate_spk = {
+    .name = "pcspk",
+    .version_id = 1,
+    .minimum_version_id = 1,
+    .minimum_version_id_old = 1,
+    .fields      = (VMStateField[]) {
+        VMSTATE_UINT8(data_on, PCSpkState),
+        VMSTATE_UINT8(dummy_refresh_clock, PCSpkState),
+        VMSTATE_END_OF_LIST()
+    }
+};
+
 static void pcspk_initfn(Object *obj)
 {
     PCSpkState *s = PC_SPEAKER(obj);
@@ -192,6 +204,7 @@ static void pcspk_class_initfn(ObjectClass *klass, void *data)
 
     dc->realize = pcspk_realizefn;
     set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
+    dc->vmsd = &vmstate_spk;
     dc->props = pcspk_properties;
     /* Reason: pointer property "pit", realize sets global pcspk_state */
     dc->cannot_instantiate_with_device_add_yet = true;

  parent reply	other threads:[~2014-08-28 11:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 11:18 [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 01/12] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2014-09-01 17:03   ` Peter Maydell
2014-08-28 11:18 ` Pavel Dovgalyuk [this message]
2014-08-28 11:56   ` [Qemu-devel] [PATCH v2 02/12] pcspk: " Paolo Bonzini
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 03/12] fdc: " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 04/12] parallel: " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 05/12] serial: fixing " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 06/12] apic_common: fixing loading vmstate Pavel Dovgalyuk
2014-08-28 12:05   ` Paolo Bonzini
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 07/12] apic_common: vapic_paddr synchronization fix Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 08/12] hpet: fixing saving and loading process Pavel Dovgalyuk
2014-08-28 11:58   ` Paolo Bonzini
2014-09-09 12:24     ` Paolo Bonzini
2014-09-09 12:28       ` Pavel Dovgaluk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 09/12] pckbd: adding new fields to vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 10/12] piix: do not raise irq while loading vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 11/12] mc146818rtc: add missed field to vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 12/12] pl031: " Pavel Dovgalyuk
2014-09-01 16:59   ` Peter Maydell
2014-09-02  9:53     ` Pavel Dovgaluk
2014-08-28 11:59 ` [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140828111835.1624.21791.stgit@PASHA-ISP \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=maria.klimushenkova@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zealot351@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).