qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, zealot351@gmail.com,
	maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru
Subject: [Qemu-devel] [PATCH v2 07/12] apic_common: vapic_paddr synchronization fix
Date: Thu, 28 Aug 2014 15:19:03 +0400	[thread overview]
Message-ID: <20140828111903.1624.46920.stgit@PASHA-ISP> (raw)
In-Reply-To: <20140828111822.1624.24556.stgit@PASHA-ISP>

This patch postpones vapic_paddr initialization, which is perfromed
by the migration functions. When vapic_paddr is synchronized within
the migration process, apic_common functions could operate with incorrect
apic state, if it hadn't loaded yet. This patch postpones the synchronization
until whole virtual machine state is loaded.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 hw/intc/apic_common.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index 2d2dfcb..c3590a6 100644
--- a/hw/intc/apic_common.c
+++ b/hw/intc/apic_common.c
@@ -91,13 +91,21 @@ void apic_enable_tpr_access_reporting(DeviceState *dev, bool enable)
     }
 }
 
+static void do_apic_enable_vapic(void *data)
+{
+    APICCommonState *s = APIC_COMMON(data);
+    APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
+
+    info->vapic_base_update(s);
+}
+
 void apic_enable_vapic(DeviceState *dev, hwaddr paddr)
 {
     APICCommonState *s = APIC_COMMON(dev);
     APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
 
     s->vapic_paddr = paddr;
-    info->vapic_base_update(s);
+    run_on_cpu(CPU(s->cpu), do_apic_enable_vapic, s);
 }
 
 void apic_handle_tpr_access_report(DeviceState *dev, target_ulong ip,

  parent reply	other threads:[~2014-08-28 11:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 11:18 [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 01/12] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2014-09-01 17:03   ` Peter Maydell
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 02/12] pcspk: " Pavel Dovgalyuk
2014-08-28 11:56   ` Paolo Bonzini
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 03/12] fdc: " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 04/12] parallel: " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 05/12] serial: fixing " Pavel Dovgalyuk
2014-08-28 11:18 ` [Qemu-devel] [PATCH v2 06/12] apic_common: fixing loading vmstate Pavel Dovgalyuk
2014-08-28 12:05   ` Paolo Bonzini
2014-08-28 11:19 ` Pavel Dovgalyuk [this message]
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 08/12] hpet: fixing saving and loading process Pavel Dovgalyuk
2014-08-28 11:58   ` Paolo Bonzini
2014-09-09 12:24     ` Paolo Bonzini
2014-09-09 12:28       ` Pavel Dovgaluk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 09/12] pckbd: adding new fields to vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 10/12] piix: do not raise irq while loading vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 11/12] mc146818rtc: add missed field to vmstate Pavel Dovgalyuk
2014-08-28 11:19 ` [Qemu-devel] [PATCH v2 12/12] pl031: " Pavel Dovgalyuk
2014-09-01 16:59   ` Peter Maydell
2014-09-02  9:53     ` Pavel Dovgaluk
2014-08-28 11:59 ` [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140828111903.1624.46920.stgit@PASHA-ISP \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=maria.klimushenkova@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zealot351@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).