From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, peter.crosthwaite@xilinx.com, mjt@tls.msk.ru,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/7] build-sys: Fix iscsi module loading failure
Date: Thu, 28 Aug 2014 20:12:12 +0800 [thread overview]
Message-ID: <20140828121212.GA19145@T430.redhat.com> (raw)
In-Reply-To: <20140828111751.GJ26741@stefanha-thinkpad.redhat.com>
On Thu, 08/28 12:17, Stefan Hajnoczi wrote:
> On Mon, Aug 25, 2014 at 10:27:07AM +0800, Fam Zheng wrote:
> > On Fri, 08/22 14:35, Stefan Hajnoczi wrote:
> > > Did you compare the before/after binary size with your patch? Please
> > > use size(1).
> >
> > Before:
> >
> > text data bss dec hex filename
> > 24264 3016 8 27288 6a98 /home/fam/build/master/block-iscsi.so
> > 24264 3016 8 27288 6a98 /home/fam/build/master/block/iscsi.so
> > 35356 2272 4440 42068 a454 /home/fam/build/master/fsdev/virtfs-proxy-helper
> > 392541 7568 4672 404781 62d2d /home/fam/build/master/qemu-ga
> > 878979 33168 4204568 5116715 4e132b /home/fam/build/master/qemu-img
> > 904801 57784 4208664 5171249 4ee831 /home/fam/build/master/qemu-io
> > 854255 32872 4204504 5091631 4db12f /home/fam/build/master/qemu-nbd
> > 4896094 1293960 4727496 10917550 a696ae /home/fam/build/master/x86_64-softmmu/qemu-system-x86_64
> >
> > After:
> >
> > text data bss dec hex filename
> > 23852 2992 8 26852 68e4 /home/fam/build/iscsi-modules/block-iscsi.so
> > 23852 2992 8 26852 68e4 /home/fam/build/iscsi-modules/block/iscsi.so
> > 509345 32488 5192 547025 858d1 /home/fam/build/iscsi-modules/fsdev/virtfs-proxy-helper
> > 563169 33312 5192 601673 92e49 /home/fam/build/iscsi-modules/qemu-ga
> > 966709 58304 4204632 5229645 4fcc4d /home/fam/build/iscsi-modules/qemu-img
> > 940145 58088 4208792 5207025 4f73f1 /home/fam/build/iscsi-modules/qemu-io
> > 943434 58048 4204632 5206114 4f7062 /home/fam/build/iscsi-modules/qemu-nbd
> > 4904197 1293944 4727560 10925701 a6b685 /home/fam/build/iscsi-modules/x86_64-softmmu/qemu-system-x86_64
>
> It doesn't have a big impact on the QEMU binary. The QEMU tools do get
> a bit bloated though.
>
> I guess I'm happy with this approach.
>
OK. I'm working on an alternative approach (-Wl,-u,SYMBOL) as suggested by the
binutils developer:
https://sourceware.org/bugzilla/show_bug.cgi?id=17306#c5
(Also as said in the comment, --just-symbols may not be a right way to do this.)
I'll post it later for comparison, and we can choose one between them.
Thanks,
Fam
next prev parent reply other threads:[~2014-08-28 12:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 10:54 [Qemu-devel] [PATCH v2 0/7] build-sys: Fix iscsi module loading failure Fam Zheng
2014-08-22 10:54 ` [Qemu-devel] [PATCH v2 1/7] build-sys: Move fifo8.c to hw/misc Fam Zheng
2014-08-22 12:20 ` Peter Crosthwaite
2014-08-22 10:54 ` [Qemu-devel] [PATCH v2 2/7] configure: Add -lutil to libs_qga if necessary Fam Zheng
2014-08-22 10:54 ` [Qemu-devel] [PATCH v2 3/7] stubs: Add iohandler.c Fam Zheng
2014-08-22 10:54 ` [Qemu-devel] [PATCH v2 4/7] stubs: Merge set-fd-handler.c into iohandler.c Fam Zheng
2014-08-22 10:54 ` [Qemu-devel] [PATCH v2 5/7] util: Move throttle.c out to top level Fam Zheng
2014-08-25 13:22 ` Paolo Bonzini
2014-08-22 10:54 ` [Qemu-devel] [PATCH v2 6/7] build-sys: Change libqemuutil.a to qemuutil.o and link whole object Fam Zheng
2014-08-22 10:54 ` [Qemu-devel] [PATCH v2 7/7] iscsi: Move iqn generation code to util Fam Zheng
2014-08-22 13:35 ` [Qemu-devel] [PATCH v2 0/7] build-sys: Fix iscsi module loading failure Stefan Hajnoczi
2014-08-22 13:42 ` Paolo Bonzini
2014-08-25 2:27 ` Fam Zheng
2014-08-28 11:17 ` Stefan Hajnoczi
2014-08-28 12:12 ` Fam Zheng [this message]
2014-08-28 12:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828121212.GA19145@T430.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).