From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40877)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XMys3-0000Hg-Re
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:32:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XMyry-0004bn-Dv
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:32:07 -0400
Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:59184)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XMyry-0004bX-6x
	for qemu-devel@nongnu.org; Thu, 28 Aug 2014 08:32:02 -0400
Received: by mail-we0-f182.google.com with SMTP id w62so696931wes.27
	for <qemu-devel@nongnu.org>; Thu, 28 Aug 2014 05:32:01 -0700 (PDT)
Date: Thu, 28 Aug 2014 13:31:58 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140828123158.GP26741@stefanha-thinkpad.redhat.com>
References: <1409146199-12855-1-git-send-email-stefanha@redhat.com>
	<53FDDE19.3080708@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="PdAWLd+WEPmMbsbx"
Content-Disposition: inline
In-Reply-To: <53FDDE19.3080708@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity'
 error message
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>


--PdAWLd+WEPmMbsbx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote:
> buf-size has the same bug a few lines later; might as well fix both at once.

Hmm...which git tree are you looking at?

I don't see any error paths for buf_size:
http://git.qemu-project.org/?p=qemu.git;a=blob;f=blockdev.c;h=6a204c662d4b648c78a379f5b8e8120254dde479;hb=HEAD#l2140

Stefan

--PdAWLd+WEPmMbsbx
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJT/yE+AAoJEJykq7OBq3PIBVMIAL7NELjnVmrytKGzd9atvSmy
yHDqEfOZJuOaC2i5IHFqde7wN7qGP2lkbJmF+kjGcKB2aOZxB17uPljUs9/LQ6wi
Tw+8gWB6LJtgQTy+1nQW0bjmRYmb93qhCvNNIR+tJl98LO5uUTPtjRn1W+RvhH/n
QJIKeALO12jBxs+bmUYzU0sDUhC3LzGlyDeI6OjZw/q8Xv4xtJj2wa0v2ctORtO8
FPR7ukVKH/rfwN+yaG1wUnBLeMY6tXKfgjx+sOerMWhScR21Ki9I7eQlg2BXPyMm
agMAFhHz3ps9qMvmiueUd8kt260MabJeYzdf14Hy1KAZ8oDM90higzg4KI8tUCg=
=Vy71
-----END PGP SIGNATURE-----

--PdAWLd+WEPmMbsbx--