qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Always compile virtio-blk dataplane
Date: Thu, 28 Aug 2014 14:56:25 +0100	[thread overview]
Message-ID: <20140828135625.GA21702@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1409036239-592-1-git-send-email-famz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Tue, Aug 26, 2014 at 02:57:19PM +0800, Fam Zheng wrote:
> Dataplane doesn't depend on linux-aio any more, so we don't need the
> compiling condition now.
> 
> Configure options are kept but just print a message.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  configure                      | 21 ++-------------------
>  hw/block/Makefile.objs         |  2 +-
>  hw/block/virtio-blk.c          | 22 ++--------------------
>  hw/virtio/Makefile.objs        |  2 +-
>  include/hw/virtio/virtio-blk.h |  2 --
>  5 files changed, 6 insertions(+), 43 deletions(-)

Oops, mingw cross-compiling no longer works:

In file included from hw/virtio/dataplane/vring.c:21:0:
/home/stefanha/qemu/include/hw/virtio/dataplane/vring.h:20:31: fatal error: linux/virtio_ring.h: No such file or directory
 #include <linux/virtio_ring.h>
           ^
compilation terminated.
make: *** [hw/virtio/dataplane/vring.o] Error 1

I have dropped this patch for now.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2014-08-28 13:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  6:57 [Qemu-devel] [PATCH] block: Always compile virtio-blk dataplane Fam Zheng
2014-08-26 11:02 ` Paolo Bonzini
2014-08-26 15:07 ` Benoît Canet
2014-08-27 11:44 ` Stefan Hajnoczi
2014-08-28 13:56 ` Stefan Hajnoczi [this message]
2014-08-29  1:11   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140828135625.GA21702@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).