From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNI4w-0007WK-9h for qemu-devel@nongnu.org; Fri, 29 Aug 2014 05:02:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNI4r-0006To-Sg for qemu-devel@nongnu.org; Fri, 29 Aug 2014 05:02:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNI4r-0006Tj-Kl for qemu-devel@nongnu.org; Fri, 29 Aug 2014 05:02:37 -0400 Date: Thu, 28 Aug 2014 20:16:22 +0100 From: Stefan Hajnoczi Message-ID: <20140828191622.GB12453@stefanha-thinkpad.redhat.com> References: <1409212630-8185-1-git-send-email-namei.unix@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline In-Reply-To: <1409212630-8185-1-git-send-email-namei.unix@gmail.com> Subject: Re: [Qemu-devel] [PATCH] sheepdog: fix a core dump while do auto-reconnecting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yuan Cc: Kevin Wolf , sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, Markus Armbruster --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 28, 2014 at 03:57:10PM +0800, Liu Yuan wrote: > We should reinit Local_err as NULL inside the while loop or g_free() will= report > corrupption and abort the QEMU when sheepdog driver tries reconnecting. >=20 > qemu-system-x86_64: failed to get the header, Resource temporarily unavai= lable > qemu-system-x86_64: Failed to connect to socket: Connection refused > qemu-system-x86_64: (null) > [xcb] Unknown sequence number while awaiting reply > [xcb] Most likely this is a multi-threaded client and XInitThreads has no= t been called > [xcb] Aborting, sorry about that. > qemu-system-x86_64: ../../src/xcb_io.c:298: poll_for_response: Assertion = `!xcb_xlib_threads_sequence_lost' failed. > Aborted (core dumped) >=20 > Cc: qemu-devel@nongnu.org > Cc: Markus Armbruster > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/sheepdog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT/4AGAAoJEJykq7OBq3PIwqkH/A8djyOpM0ANKO/FdzkwYA81 B4bK8CKHa9vbh3a8EufXnrQAZ20ALOif+72cn9/JD89c86Ve3tt5zGJcgQfYCPkH iXy8hQoIIZxWKl2f62wtSa7o+U+g9j6//vuAKiUxMyjFDfXmPH8IQGSGkMevAs1G i6rCl36/e3CKbk28LYZ6avTKlIP2/8XuMDL0NgBmkl3cJGAXT1PZ2U2NcG3cwHKP 2HcvVUzvmk6PN+RhIVrzW9pMbwMKQ2XDnrIzYs292bkbotksALPdcpgBE9cdu5z/ TXnstCtWY8k3t5QLJ05KdQIGxuZ6Bt3HzpKE7Taq11hGF7/lubx/xb7n65AltZI= =KhrM -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML--