From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN9S2-0001mx-9p for qemu-devel@nongnu.org; Thu, 28 Aug 2014 19:50:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XN9Rx-0004BD-CE for qemu-devel@nongnu.org; Thu, 28 Aug 2014 19:49:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN9Rx-0004B7-4P for qemu-devel@nongnu.org; Thu, 28 Aug 2014 19:49:53 -0400 Date: Fri, 29 Aug 2014 07:50:03 +0800 From: Fam Zheng Message-ID: <20140828235003.GA4196@T430.redhat.com> References: <87oave58q3.fsf@blackfin.pond.sub.org> <20140821131237.GA22844@stefanha-thinkpad.redhat.com> <20140828110556.GH26741@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140828110556.GH26741@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] What tests should "make check-block" run? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Peter Maydell , Markus Armbruster , Stefan Hajnoczi , QEMU Developers On Thu, 08/28 12:05, Stefan Hajnoczi wrote: > On Thu, Aug 21, 2014 at 02:16:36PM +0100, Peter Maydell wrote: > > On 21 August 2014 14:12, Stefan Hajnoczi wrote: > > > On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote: > > >> Should we have a variant of "make check-block" for testing other > > >> (format, protocol) combinations? > > > > > > I don't think variants are useful. If you need control, use ./check. > > > > That seems pretty undiscoverable to me. I know about 'make check', > > and 'make check-help' tells me about 'make check-block', but how > > do I find out about 'check' ? I just had to bounce through the makefile > > and a wrapper script to even figure out which directory it lives in, > > and there's no help text or usage comments in it... > > http://qemu-project.org/Documentation/QemuIoTests > > Any suggestions for making it more discoverable? > Maybe mention it in http://qemu-project.org/Testing or http://qemu-project.org/Contribute/SubmitAPatch ? Fam