From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNDvG-0005oe-NV for qemu-devel@nongnu.org; Fri, 29 Aug 2014 00:36:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNDv8-0001sc-B8 for qemu-devel@nongnu.org; Fri, 29 Aug 2014 00:36:26 -0400 Date: Fri, 29 Aug 2014 13:46:35 +1000 From: David Gibson Message-ID: <20140829034635.GD1930@voom.redhat.com> References: <20140825134353.2361.52046.stgit@aravindap> <20140825134516.2361.32987.stgit@aravindap> <53FF0732.6090008@suse.de> <53FF72DD.5010009@linux.vnet.ibm.com> <53FFAAC4.2050408@suse.de> <1409264725.17335.23.camel@pasglop> <53FFCBEC.6030703@suse.de> <1409274364.17335.28.camel@pasglop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GpGaEY17fSl8rd50" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Benjamin Herrenschmidt , "aik@au1.ibm.com" , "qemu-devel@nongnu.org" , "qemu-ppc@nongnu.org" , Aravinda Prasad , "paulus@samba.org" --GpGaEY17fSl8rd50 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 29, 2014 at 03:33:59AM +0200, Alexander Graf wrote: >=20 >=20 > > Am 29.08.2014 um 03:06 schrieb Benjamin Herrenschmidt : > >=20 > >> On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote: > >>=20 > >>> On 29.08.14 00:25, Benjamin Herrenschmidt wrote: > >>>> On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: > >>>> I strongly disagree with David. Legally there is no difference betwe= en a > >>>> .bin file that contains code and an array made of instructions. And = the > >>>> more target code we can keep outside of QEMU the better. > >>>=20 > >>> Ugh ... having a separate file with it's own build system etc... for 5 > >>> instructions is borderline ridiculous too :-) > >>=20 > >> Then don't use it - nobody's forcing you to do so :). Just use the > >> provided binary. I fail to see the difference between > >>=20 > >> uint32_t rtas_blob[] =3D { INST_SC1, INST_BLR }; > >>=20 > >> and > >>=20 > >> uint32_t *rtas_blob; > >> load_file_from_disk(rtas_blob); > >>=20 > >> except that we're using an actual assembler ;). > >=20 > > So you fail to see the difference with an array of 5 words vs. running > > through thousands of instructions & syscall to read those same 5 words > > from disk ? :-) >=20 > I fail to see a problem, yeah :). Imagine the same thing on x86 with > its completely messed up instruction set. Would you still advocate > for in-qemu code or would you prefer to have a compiler between you > and the ugly opcodes? If it was only 20 bytes worth, and by it's nature unlikely to need changing, then, yes, I would, even with the extra x86 ugliness. Assuming it was well commented, obviously. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GpGaEY17fSl8rd50 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT//ebAAoJEGw4ysog2bOS0H8QANL8eqPwpghTOUSP1upiFYub A/eu64RcCNUmW2gip4as6W5ameqpx1ZGhWYTRMVlONuB9yS9EEdICie+KkJOZir1 JqZ09SQOxp1PslO04lU7eaPW2nLRemXgdQOz7GKDPJC6KLBW9pGXKpTNudapMNMi 5uzdsmDQ3lo/UzI+B6AfU40nawUPXOpQgu1w4nCQZPZSEFj/zFCKDygwCyB5aSFn KcLwesxLoWl1019QkjOoSkxSsj5kTZl9s+C44W1PPX3//OI6KvkECnePKhdACdCV wGOENjX3QkNu3VzT469eCgKDhwZ9YueEbkpvhWV/VG3qb/AXD/zxz2xoBXLPQqDy m14xBz0CYtEZy3TirimAJ0mBKzRXU4h0zJ8S7MZUSkxDYjD2sZdmQyyanpok5+tC tsRqHX83DVqEhgGM43okn8rAVwhOsm+zGrxl/pjCmCfFqdxwOIoTmq3mjuyTY0FR pJUF+UAhtySM0F9X78C1LRYV2Yksm5FvrcoPVyshuMxBu6/uZn5RbbuXRXGWKGoU hN/4abgXEbJmXDkYtEwiN9/fdMfmjEePM4edo9xBpnEo8L6cfAvPHVDSnwBGg391 zRjvtSFHHnxHCV+FUb5pohK30RH4Ox7N1DFsreJNy138svDSMMPVIB3QujM5RTAP sYOaFFSwgo6o7/hyJD0w =N2zD -----END PGP SIGNATURE----- --GpGaEY17fSl8rd50--