From: "Richard W.M. Jones" <rjones@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option
Date: Fri, 29 Aug 2014 09:48:01 +0100 [thread overview]
Message-ID: <20140829084801.GV1302@redhat.com> (raw)
In-Reply-To: <67d97abc587e7c6985166dbe800686938ac8adb5.1409299732.git.hutao@cn.fujitsu.com>
On Fri, Aug 29, 2014 at 04:33:12PM +0800, Hu Tao wrote:
> + if (prealloc == PREALLOC_MODE_FULL) {
> + /* posix_fallocate() doesn't set errno. */
> + result = -posix_fallocate(fd, 0, total_size);
> + if (result != 0) {
Is it better to test:
result != ENOSYS && result != EOPNOTSUPP
here?
I think this is definitely the right approach.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
next prev parent reply other threads:[~2014-08-29 8:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 8:33 [Qemu-devel] [PATCH v13 0/6] qcow2, raw: add preallocation=full Hu Tao
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 1/6] block: round up file size to nearest sector Hu Tao
2014-08-29 12:50 ` Eric Blake
2014-09-04 9:33 ` Kevin Wolf
2014-09-02 21:21 ` Max Reitz
2014-09-04 9:43 ` Kevin Wolf
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 2/6] block: don't convert file size to sector size Hu Tao
2014-09-02 21:24 ` Max Reitz
2014-09-04 9:57 ` Kevin Wolf
2014-09-05 9:07 ` Hu Tao
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 3/6] rename parse_enum_option to qapi_enum_parse and make it public Hu Tao
2014-09-02 21:27 ` Max Reitz
2014-09-03 1:30 ` Hu Tao
2014-09-04 10:03 ` Kevin Wolf
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 4/6] qapi: introduce PreallocMode and a new PreallocMode full Hu Tao
2014-09-02 21:32 ` Max Reitz
2014-09-03 1:31 ` Hu Tao
2014-09-02 21:51 ` Eric Blake
2014-09-03 1:35 ` Hu Tao
2014-09-04 12:17 ` Kevin Wolf
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option Hu Tao
2014-08-29 8:48 ` Richard W.M. Jones [this message]
2014-09-03 1:26 ` Hu Tao
2014-09-04 8:32 ` Hu Tao
2014-09-02 21:45 ` Max Reitz
2014-09-03 1:55 ` Hu Tao
2014-09-04 12:35 ` Kevin Wolf
2014-09-04 12:45 ` Richard W.M. Jones
2014-09-04 12:52 ` Kevin Wolf
2014-09-04 13:07 ` Richard W.M. Jones
2014-09-04 13:13 ` Daniel P. Berrange
2014-09-04 13:17 ` Kevin Wolf
2014-09-04 13:43 ` Richard W.M. Jones
2014-09-04 15:23 ` Kevin Wolf
2014-09-04 15:33 ` Richard W.M. Jones
2014-08-29 8:33 ` [Qemu-devel] [PATCH v13 6/6] qcow2: " Hu Tao
2014-09-02 21:55 ` Max Reitz
2014-09-04 13:09 ` Kevin Wolf
2014-09-09 3:23 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829084801.GV1302@redhat.com \
--to=rjones@redhat.com \
--cc=famz@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).