qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	mbooth@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests.
Date: Fri, 29 Aug 2014 16:28:48 +0100	[thread overview]
Message-ID: <20140829152848.GC1302@redhat.com> (raw)
In-Reply-To: <540097D2.2020200@redhat.com>

On Fri, Aug 29, 2014 at 09:10:10AM -0600, Eric Blake wrote:
> On 08/29/2014 09:03 AM, Richard W.M. Jones wrote:
> > In order to access VMware ESX efficiently, we need to send a session
> > cookie.  This patch is very simple and just allows you to send that
> > session cookie.  It punts on the question of how you get the session
> > cookie in the first place, but in practice you can just run a `curl'
> > command against the server and extract the cookie that way.
> > 
> 
> > +++ b/qemu-options.hx
> > @@ -2351,6 +2351,11 @@ multiple of 512 bytes. It defaults to 256k.
> >  @item sslverify
> >  Whether to verify the remote server's certificate when connecting over SSL. It
> >  can have the value 'on' or 'off'. It defaults to 'on'.
> > +
> > +@item cookie
> > +Send this cookie (it can also be a list of cookies separated by ';') with
> > +each outgoing request.  Only supported when using protocols such as HTTP
> > +which support cookies, otherwise ignored.
> 
> ';' has to be quoted to enter it in the shell command line (but then
> again, the cookie probably contains literal " which also has to be quoted).
> 
> We still don't have a QMP mapping for curl device hotplug.  But when we
> gain one, do we really want to have a single (long) string containing
> multiple cookies, or would it be better to make this an array argument?
>  On the command-line, which is nicer, taking the cookie option multiple
> times ('file.cookie=xyz,file.cookie.abc'), taking it as an automatic
> array ('file.cookie.0=xyz,file.cookie.1=abc') or forcing the user to
> cram all cookies into a single option ('file.cookie="xyz;abc"')?

For my immediate needs, I don't care at all about multiple cookies.
It's just a side-effect of the CURL API that they would work here.
I'm happy to drop all references to them from the documentation ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v

  reply	other threads:[~2014-08-29 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 15:03 [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https Richard W.M. Jones
2014-08-29 15:03 ` [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests Richard W.M. Jones
2014-08-29 15:06   ` Matthew Booth
2014-08-29 15:10   ` Eric Blake
2014-08-29 15:28     ` Richard W.M. Jones [this message]
2014-08-29 15:39       ` Eric Blake
2014-08-29 15:31     ` Matthew Booth
2014-08-29 15:11 ` [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140829152848.GC1302@redhat.com \
    --to=rjones@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=mbooth@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).