* [Qemu-devel] [PATCH 0/2] qemu-iotests: fix two driver-specific option filtering problems @ 2014-08-28 8:56 Hu Tao 2014-08-28 8:56 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option Hu Tao 2014-08-28 8:56 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation Hu Tao 0 siblings, 2 replies; 7+ messages in thread From: Hu Tao @ 2014-08-28 8:56 UTC (permalink / raw) To: qemu-devel; +Cc: Kevin Wolf See each patch for the details. Hu Tao (2): qemu-iotests: fix filter of encryption option qemu-iotests: filter out driver-specific option preallocation tests/qemu-iotests/common.filter | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.8.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option 2014-08-28 8:56 [Qemu-devel] [PATCH 0/2] qemu-iotests: fix two driver-specific option filtering problems Hu Tao @ 2014-08-28 8:56 ` Hu Tao 2014-08-29 16:06 ` Stefan Hajnoczi 2014-08-28 8:56 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation Hu Tao 1 sibling, 1 reply; 7+ messages in thread From: Hu Tao @ 2014-08-28 8:56 UTC (permalink / raw) To: qemu-devel; +Cc: Kevin Wolf We should filter out encryption=on, too. Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- tests/qemu-iotests/common.filter | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 51192c8..362394e 100644 --- a/tests/qemu-iotests/common.filter +++ b/tests/qemu-iotests/common.filter @@ -176,7 +176,7 @@ _filter_img_create() sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \ -e "s#$TEST_DIR#TEST_DIR#g" \ -e "s#$IMGFMT#IMGFMT#g" \ - -e "s# encryption=off##g" \ + -e "s# encryption=\\(on\\|off\\)##g" \ -e "s# cluster_size=[0-9]\\+##g" \ -e "s# table_size=[0-9]\\+##g" \ -e "s# compat='[^']*'##g" \ -- 1.8.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option 2014-08-28 8:56 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option Hu Tao @ 2014-08-29 16:06 ` Stefan Hajnoczi 2014-09-04 9:03 ` Hu Tao 0 siblings, 1 reply; 7+ messages in thread From: Stefan Hajnoczi @ 2014-08-29 16:06 UTC (permalink / raw) To: Hu Tao; +Cc: Kevin Wolf, qemu-devel [-- Attachment #1: Type: text/plain, Size: 744 bytes --] On Thu, Aug 28, 2014 at 04:56:03PM +0800, Hu Tao wrote: > We should filter out encryption=on, too. > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > --- > tests/qemu-iotests/common.filter | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter > index 51192c8..362394e 100644 > --- a/tests/qemu-iotests/common.filter > +++ b/tests/qemu-iotests/common.filter > @@ -176,7 +176,7 @@ _filter_img_create() > sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \ > -e "s#$TEST_DIR#TEST_DIR#g" \ > -e "s#$IMGFMT#IMGFMT#g" \ > - -e "s# encryption=off##g" \ > + -e "s# encryption=\\(on\\|off\\)##g" \ Why? Stefan [-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option 2014-08-29 16:06 ` Stefan Hajnoczi @ 2014-09-04 9:03 ` Hu Tao 2014-09-08 9:14 ` Stefan Hajnoczi 0 siblings, 1 reply; 7+ messages in thread From: Hu Tao @ 2014-09-04 9:03 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: Kevin Wolf, qemu-devel On Fri, Aug 29, 2014 at 05:06:20PM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 28, 2014 at 04:56:03PM +0800, Hu Tao wrote: > > We should filter out encryption=on, too. > > > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > > --- > > tests/qemu-iotests/common.filter | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter > > index 51192c8..362394e 100644 > > --- a/tests/qemu-iotests/common.filter > > +++ b/tests/qemu-iotests/common.filter > > @@ -176,7 +176,7 @@ _filter_img_create() > > sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \ > > -e "s#$TEST_DIR#TEST_DIR#g" \ > > -e "s#$IMGFMT#IMGFMT#g" \ > > - -e "s# encryption=off##g" \ > > + -e "s# encryption=\\(on\\|off\\)##g" \ > > Why? This is considered a bug of _filter_img_create(). It should have filtered out driver specific option 'encryption=on', too. Regards, Hu ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option 2014-09-04 9:03 ` Hu Tao @ 2014-09-08 9:14 ` Stefan Hajnoczi 0 siblings, 0 replies; 7+ messages in thread From: Stefan Hajnoczi @ 2014-09-08 9:14 UTC (permalink / raw) To: Hu Tao; +Cc: Kevin Wolf, qemu-devel [-- Attachment #1: Type: text/plain, Size: 1296 bytes --] On Thu, Sep 04, 2014 at 05:03:01PM +0800, Hu Tao wrote: > On Fri, Aug 29, 2014 at 05:06:20PM +0100, Stefan Hajnoczi wrote: > > On Thu, Aug 28, 2014 at 04:56:03PM +0800, Hu Tao wrote: > > > We should filter out encryption=on, too. > > > > > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > > > --- > > > tests/qemu-iotests/common.filter | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter > > > index 51192c8..362394e 100644 > > > --- a/tests/qemu-iotests/common.filter > > > +++ b/tests/qemu-iotests/common.filter > > > @@ -176,7 +176,7 @@ _filter_img_create() > > > sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \ > > > -e "s#$TEST_DIR#TEST_DIR#g" \ > > > -e "s#$IMGFMT#IMGFMT#g" \ > > > - -e "s# encryption=off##g" \ > > > + -e "s# encryption=\\(on\\|off\\)##g" \ > > > > Why? > > This is considered a bug of _filter_img_create(). It should have filtered out > driver specific option 'encryption=on', too. You have not posted justification for this patch series. As far as I know, there is no reason to filter these options. And your series breaks qemu-iotests because you didn't update the .out files. NACK Stefan [-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation 2014-08-28 8:56 [Qemu-devel] [PATCH 0/2] qemu-iotests: fix two driver-specific option filtering problems Hu Tao 2014-08-28 8:56 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option Hu Tao @ 2014-08-28 8:56 ` Hu Tao 2014-08-29 16:07 ` Stefan Hajnoczi 1 sibling, 1 reply; 7+ messages in thread From: Hu Tao @ 2014-08-28 8:56 UTC (permalink / raw) To: qemu-devel; +Cc: Kevin Wolf Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- tests/qemu-iotests/common.filter | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 362394e..97d2934 100644 --- a/tests/qemu-iotests/common.filter +++ b/tests/qemu-iotests/common.filter @@ -189,6 +189,7 @@ _filter_img_create() -e "s# block_size=[0-9]\\+##g" \ -e "s# block_state_zero=\\(on\\|off\\)##g" \ -e "s# log_size=[0-9]\\+##g" \ + -e "s# preallocation='[^']*'##g" \ -e "s/archipelago:a/TEST_DIR\//g" } -- 1.8.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation 2014-08-28 8:56 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation Hu Tao @ 2014-08-29 16:07 ` Stefan Hajnoczi 0 siblings, 0 replies; 7+ messages in thread From: Stefan Hajnoczi @ 2014-08-29 16:07 UTC (permalink / raw) To: Hu Tao; +Cc: Kevin Wolf, qemu-devel [-- Attachment #1: Type: text/plain, Size: 878 bytes --] On Thu, Aug 28, 2014 at 04:56:04PM +0800, Hu Tao wrote: > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > --- > tests/qemu-iotests/common.filter | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter > index 362394e..97d2934 100644 > --- a/tests/qemu-iotests/common.filter > +++ b/tests/qemu-iotests/common.filter > @@ -189,6 +189,7 @@ _filter_img_create() > -e "s# block_size=[0-9]\\+##g" \ > -e "s# block_state_zero=\\(on\\|off\\)##g" \ > -e "s# log_size=[0-9]\\+##g" \ > + -e "s# preallocation='[^']*'##g" \ > -e "s/archipelago:a/TEST_DIR\//g" > } This seems bogus. Why does this patch filter the option without updating all the tests/qemu-iotests/*.out files that contain this output? What is the point of this patch? Stefan [-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-09-08 9:14 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-28 8:56 [Qemu-devel] [PATCH 0/2] qemu-iotests: fix two driver-specific option filtering problems Hu Tao 2014-08-28 8:56 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option Hu Tao 2014-08-29 16:06 ` Stefan Hajnoczi 2014-09-04 9:03 ` Hu Tao 2014-09-08 9:14 ` Stefan Hajnoczi 2014-08-28 8:56 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation Hu Tao 2014-08-29 16:07 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).