From: Stefan Hajnoczi <stefanha@gmail.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation
Date: Fri, 29 Aug 2014 17:07:56 +0100 [thread overview]
Message-ID: <20140829160756.GF20193@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <0ffebfb3a9c656a58a3917a22a4600a9b848a522.1409216371.git.hutao@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On Thu, Aug 28, 2014 at 04:56:04PM +0800, Hu Tao wrote:
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
> tests/qemu-iotests/common.filter | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
> index 362394e..97d2934 100644
> --- a/tests/qemu-iotests/common.filter
> +++ b/tests/qemu-iotests/common.filter
> @@ -189,6 +189,7 @@ _filter_img_create()
> -e "s# block_size=[0-9]\\+##g" \
> -e "s# block_state_zero=\\(on\\|off\\)##g" \
> -e "s# log_size=[0-9]\\+##g" \
> + -e "s# preallocation='[^']*'##g" \
> -e "s/archipelago:a/TEST_DIR\//g"
> }
This seems bogus.
Why does this patch filter the option without updating all the
tests/qemu-iotests/*.out files that contain this output?
What is the point of this patch?
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-08-29 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 8:56 [Qemu-devel] [PATCH 0/2] qemu-iotests: fix two driver-specific option filtering problems Hu Tao
2014-08-28 8:56 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option Hu Tao
2014-08-29 16:06 ` Stefan Hajnoczi
2014-09-04 9:03 ` Hu Tao
2014-09-08 9:14 ` Stefan Hajnoczi
2014-08-28 8:56 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation Hu Tao
2014-08-29 16:07 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829160756.GF20193@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).