qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration
@ 2014-08-25 12:20 arei.gonglei
  2014-09-01  1:44 ` Gonglei (Arei)
  2014-09-01  6:45 ` Michael S. Tsirkin
  0 siblings, 2 replies; 3+ messages in thread
From: arei.gonglei @ 2014-08-25 12:20 UTC (permalink / raw)
  To: qemu-devel; +Cc: knut.omang, Gonglei, weidong.huang, armbru, mst

From: Gonglei <arei.gonglei@huawei.com>

This patch based on Knut's patch:

ioh3420: Remove unused ioh3420_init() declaration

which has been pulled on the fly.

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Knut Omang <knut.omang@oracle.com>
---
v2:
 - add commit message to state the patch's prerequisites.
 - add 'Reviewed-by' tag
---
 hw/pci-bridge/ioh3420.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h
index 7776e5b..ea423cb 100644
--- a/hw/pci-bridge/ioh3420.h
+++ b/hw/pci-bridge/ioh3420.h
@@ -3,8 +3,4 @@
 
 #include "hw/pci/pcie_port.h"
 
-PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction,
-                       const char *bus_name, pci_map_irq_fn map_irq,
-                       uint8_t port, uint8_t chassis, uint16_t slot);
-
 #endif /* QEMU_IOH3420_H */
-- 
1.7.12.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration
  2014-08-25 12:20 [Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration arei.gonglei
@ 2014-09-01  1:44 ` Gonglei (Arei)
  2014-09-01  6:45 ` Michael S. Tsirkin
  1 sibling, 0 replies; 3+ messages in thread
From: Gonglei (Arei) @ 2014-09-01  1:44 UTC (permalink / raw)
  To: Gonglei (Arei), qemu-devel@nongnu.org
  Cc: knut.omang@oracle.com, Huangweidong (C), armbru@redhat.com,
	mst@redhat.com

Hi, Michael

Do you plan to pick up this patch? Thanks.

Best regards,
-Gonglei

> -----Original Message-----
> From: Gonglei (Arei)
> Sent: Monday, August 25, 2014 8:21 PM
> To: qemu-devel@nongnu.org
> Cc: mst@redhat.com; Huangweidong (C); knut.omang@oracle.com;
> armbru@redhat.com; Gonglei (Arei)
> Subject: [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration
> 
> From: Gonglei <arei.gonglei@huawei.com>
> 
> This patch based on Knut's patch:
> 
> ioh3420: Remove unused ioh3420_init() declaration
> 
> which has been pulled on the fly.
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Knut Omang <knut.omang@oracle.com>
> ---
> v2:
>  - add commit message to state the patch's prerequisites.
>  - add 'Reviewed-by' tag
> ---
>  hw/pci-bridge/ioh3420.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h
> index 7776e5b..ea423cb 100644
> --- a/hw/pci-bridge/ioh3420.h
> +++ b/hw/pci-bridge/ioh3420.h
> @@ -3,8 +3,4 @@
> 
>  #include "hw/pci/pcie_port.h"
> 
> -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction,
> -                       const char *bus_name, pci_map_irq_fn map_irq,
> -                       uint8_t port, uint8_t chassis, uint16_t slot);
> -
>  #endif /* QEMU_IOH3420_H */
> --
> 1.7.12.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration
  2014-08-25 12:20 [Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration arei.gonglei
  2014-09-01  1:44 ` Gonglei (Arei)
@ 2014-09-01  6:45 ` Michael S. Tsirkin
  1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2014-09-01  6:45 UTC (permalink / raw)
  To: arei.gonglei; +Cc: knut.omang, weidong.huang, qemu-devel, armbru

On Mon, Aug 25, 2014 at 08:20:31PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> This patch based on Knut's patch:
> 
> ioh3420: Remove unused ioh3420_init() declaration
> 
> which has been pulled on the fly.
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Knut Omang <knut.omang@oracle.com>

Applied.

> ---
> v2:
>  - add commit message to state the patch's prerequisites.
>  - add 'Reviewed-by' tag
> ---
>  hw/pci-bridge/ioh3420.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h
> index 7776e5b..ea423cb 100644
> --- a/hw/pci-bridge/ioh3420.h
> +++ b/hw/pci-bridge/ioh3420.h
> @@ -3,8 +3,4 @@
>  
>  #include "hw/pci/pcie_port.h"
>  
> -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction,
> -                       const char *bus_name, pci_map_irq_fn map_irq,
> -                       uint8_t port, uint8_t chassis, uint16_t slot);
> -
>  #endif /* QEMU_IOH3420_H */
> -- 
> 1.7.12.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-01  6:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-25 12:20 [Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration arei.gonglei
2014-09-01  1:44 ` Gonglei (Arei)
2014-09-01  6:45 ` Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).