From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Liu Yuan <namei.unix@gmail.com>
Cc: "Benoît Canet" <benoit.canet@irqsave.net>,
"Kevin Wolf" <kwolf@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()
Date: Mon, 1 Sep 2014 11:32:04 +0200 [thread overview]
Message-ID: <20140901093203.GJ15537@irqsave.net> (raw)
In-Reply-To: <20140901092609.GE720@ubuntu-trusty>
The Monday 01 Sep 2014 à 17:26:09 (+0800), Liu Yuan wrote :
> On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote:
> > The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote :
> > > For a fifo read pattern, we only have one running aio
> >
> > >(possible other cases that has less number than num_children in the future)
> > I have trouble understanding this part of the commit message could you try
> > to clarify it ?
>
> Until this patch, we have two cases, read single or read all. But later patch
> allow VMs to continue if some devices are down. So the discrete number 1 and N
> becomes a range [1, N], that is possible running requests are from 1 to N.
Why not
(In some other cases some children of the num_children BDS could be disabled
reducing the number of requests needed) ?
>
> Thanks
> Yuan
next prev parent reply other threads:[~2014-09-01 9:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 7:43 [Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver Liu Yuan
2014-09-01 7:43 ` [Qemu-devel] [PATCH 1/8] block/quorum: initialize qcrs.aiocb for read Liu Yuan
2014-09-01 7:43 ` [Qemu-devel] [PATCH 2/8] block: add driver operation callbacks Liu Yuan
2014-09-01 8:28 ` Benoît Canet
2014-09-01 9:19 ` Liu Yuan
2014-09-01 9:28 ` Benoît Canet
2014-09-01 9:40 ` Liu Yuan
2014-09-01 7:43 ` [Qemu-devel] [PATCH 3/8] block/sheepdog: propagate disconnect/reconnect events to upper driver Liu Yuan
2014-09-01 8:31 ` Benoît Canet
2014-09-01 9:22 ` Liu Yuan
2014-09-01 7:43 ` [Qemu-devel] [PATCH 4/8] block/quorum: add quorum_aio_release() helper Liu Yuan
2014-09-01 8:33 ` Benoît Canet
2014-09-01 7:43 ` [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel() Liu Yuan
2014-09-01 8:35 ` Benoît Canet
2014-09-01 9:26 ` Liu Yuan
2014-09-01 9:32 ` Benoît Canet [this message]
2014-09-01 9:46 ` Liu Yuan
2014-09-01 7:43 ` [Qemu-devel] [PATCH 6/8] block/quorum: add broken state to BlockDriverState Liu Yuan
2014-09-01 8:57 ` Benoît Canet
2014-09-01 9:30 ` Liu Yuan
2014-09-01 7:43 ` [Qemu-devel] [PATCH 7/8] block: add two helpers Liu Yuan
2014-09-01 8:59 ` Benoît Canet
2014-09-01 7:43 ` [Qemu-devel] [PATCH 8/8] quorum: add basic device recovery logic Liu Yuan
2014-09-01 9:37 ` Benoît Canet
2014-09-01 9:45 ` Liu Yuan
2014-09-01 8:19 ` [Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver Benoît Canet
2014-09-02 22:19 ` Benoît Canet
2014-09-10 7:31 ` Liu Yuan
2014-09-07 15:12 ` Benoît Canet
2014-09-10 7:18 ` Liu Yuan
2014-09-10 13:12 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901093203.GJ15537@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=namei.unix@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).